Merged
Conversation
Contributor
RFBomb
commented
Apr 16, 2026
RFBomb
commented
- Adds EnsureInitialized() and EnsureInitializedAsync to the RefreshableSelectors to allow callers to conditionally perform the first refresh and wait for its completion.
- Added RefreshFailedException to allow EnsureInitialized to provide more details about the failure
- Adds EnsureInitialized() and EnsureInitializedAsync to the RefreshableSelectors to allow callers to conditionally perform the first refresh and wait for its completion. - Added RefreshFailedException to allow EnsureInitialized to provide more details about the failure
There was a problem hiding this comment.
Pull request overview
This PR adds “ensure initialized” APIs to RefreshableSelector so callers can trigger the first refresh only when needed and (optionally) wait for it, with failures surfaced via a dedicated RefreshFailedException.
Changes:
- Added
EnsureInitialized()/EnsureInitializedAsync(CancellationToken)toRefreshableSelector, plus supporting initialization state tracking. - Introduced
RefreshFailedExceptionto wrap/standardize initialization failures. - Expanded
RefreshableSelectorTeststo cover initialization behavior, failure paths, and some async refresh behaviors.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
src/Mvvm.Controls/Mvvm/RefreshableSelector.cs |
Adds initialization APIs and changes initialization/refresh state handling. |
src/Mvvm.Controls/Mvvm/RefreshFailedException.cs |
New exception type used by EnsureInitialized APIs. |
src/Mvvm.Controls/SystemExtensions.cs |
Adds an int CompareExchange extension used for atomic state transitions. |
tests/MvvmControlsTests/Mvvm.Tests/RefreshableSelectorTests.cs |
Adds tests for EnsureInitialized/EnsureInitializedAsync and refresh cancellation behavior. |
src/Mvvm.Version.targets |
Bumps solution version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolved issue with spinwait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.