Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
5e8b8d3 to
96fa4ab
Compare
96fa4ab to
20dd1bd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 20dd1bd. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
=======================================
Coverage 96.98% 96.98%
=======================================
Files 129 129
Lines 7574 7574
=======================================
Hits 7346 7346
Misses 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Actually one more thought from my side before merging: we are providing a single shared library build for standard gcc11 (svs-shared-library-0.3.0-reduced.tar.gz) which is meant to work with gcc11-13 - I believe the same breadth of support would be applicable here. Could you check if the clang21-gcc11 build works for gcc12 and gcc13 as well? Unless it breaks stuff (but I believe the LTO strictness would only apply to clang version) or performs worse, it would be great to consolidate to a single library |

Extend SVS_URL logic with new binaries from Intel for older systems, in order to enable LTO compilation between C and Rust for these platforms in RediSearch.
The binaries are currently named "nightly", but those links are permanent. They will be renamed in a coming SVS release.
RediSearch workflow run pointing to this commit
https://github.com/RediSearch/RediSearch/actions/runs/24208329013
Note
Medium Risk
Build-time logic now runs compiled probes to select SVS prebuilt binaries and may change which artifacts (or source builds) are used on different Linux toolchains, potentially breaking CI or user builds if detection/matrix assumptions are wrong.
Overview
Updates
cmake/svs.cmaketo replace compile-and-run GLIBC feature checks withtry_runprobes that capture the exact detectedGLIBCversion and_GLIBCXX_RELEASE(libstdc++ header/GCC major) at configure time.Extends
SVS_URLselection to support new Intel nightly SVS shared-library binaries for Clang 21 (with GLIBC >= 2.31) and chooses the artifact based on detected libstdc++ release (GCC 11/12/13); otherwise it disablesSVS_SHARED_LIBwith updated gating messages. GCC-path selection is also adjusted to use the detected GLIBC version string (>=2.28, fallback >=2.26) when picking existing v0.3.0 binaries.Reviewed by Cursor Bugbot for commit 88e5ff2. Bugbot is set up for automated code reviews on this repo. Configure here.