Skip to content

Extend SVS_URL logic with new binaries#928

Merged
memark merged 4 commits intomainfrom
memark_new_intel_binaries
Apr 10, 2026
Merged

Extend SVS_URL logic with new binaries#928
memark merged 4 commits intomainfrom
memark_new_intel_binaries

Conversation

@memark
Copy link
Copy Markdown
Collaborator

@memark memark commented Apr 6, 2026

Extend SVS_URL logic with new binaries from Intel for older systems, in order to enable LTO compilation between C and Rust for these platforms in RediSearch.

The binaries are currently named "nightly", but those links are permanent. They will be renamed in a coming SVS release.

RediSearch workflow run pointing to this commit
https://github.com/RediSearch/RediSearch/actions/runs/24208329013


Note

Medium Risk
Build-time logic now runs compiled probes to select SVS prebuilt binaries and may change which artifacts (or source builds) are used on different Linux toolchains, potentially breaking CI or user builds if detection/matrix assumptions are wrong.

Overview
Updates cmake/svs.cmake to replace compile-and-run GLIBC feature checks with try_run probes that capture the exact detected GLIBC version and _GLIBCXX_RELEASE (libstdc++ header/GCC major) at configure time.

Extends SVS_URL selection to support new Intel nightly SVS shared-library binaries for Clang 21 (with GLIBC >= 2.31) and chooses the artifact based on detected libstdc++ release (GCC 11/12/13); otherwise it disables SVS_SHARED_LIB with updated gating messages. GCC-path selection is also adjusted to use the detected GLIBC version string (>=2.28, fallback >=2.26) when picking existing v0.3.0 binaries.

Reviewed by Cursor Bugbot for commit 88e5ff2. Bugbot is set up for automated code reviews on this repo. Configure here.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 6, 2026

CLA assistant check
All committers have signed the CLA.

@jit-ci
Copy link
Copy Markdown

jit-ci bot commented Apr 6, 2026

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@jit-ci
Copy link
Copy Markdown

jit-ci bot commented Apr 6, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@memark memark force-pushed the memark_new_intel_binaries branch from 5e8b8d3 to 96fa4ab Compare April 7, 2026 06:57
@memark memark marked this pull request as ready for review April 9, 2026 12:10
@memark memark force-pushed the memark_new_intel_binaries branch from 96fa4ab to 20dd1bd Compare April 9, 2026 12:12
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 20dd1bd. Configure here.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.98%. Comparing base (f177c40) to head (88e5ff2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #928   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         129      129           
  Lines        7574     7574           
=======================================
  Hits         7346     7346           
  Misses        228      228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@memark memark requested a review from ethanglaser April 9, 2026 19:04
@ethanglaser
Copy link
Copy Markdown
Collaborator

Actually one more thought from my side before merging: we are providing a single shared library build for standard gcc11 (svs-shared-library-0.3.0-reduced.tar.gz) which is meant to work with gcc11-13 - I believe the same breadth of support would be applicable here. Could you check if the clang21-gcc11 build works for gcc12 and gcc13 as well? Unless it breaks stuff (but I believe the LTO strictness would only apply to clang version) or performs worse, it would be great to consolidate to a single library

@memark memark added this pull request to the merge queue Apr 10, 2026
@memark memark removed this pull request from the merge queue due to a manual request Apr 10, 2026
@memark memark added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit 32cb7f2 Apr 10, 2026
17 checks passed
@memark memark deleted the memark_new_intel_binaries branch April 10, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants