[8.2] MOD-14618 Fix race condition when calling indexLabelCount on SVS without locks#930
Open
github-actions[bot] wants to merge 1 commit into8.2from
Open
[8.2] MOD-14618 Fix race condition when calling indexLabelCount on SVS without locks#930github-actions[bot] wants to merge 1 commit into8.2from
indexLabelCount on SVS without locks#930github-actions[bot] wants to merge 1 commit into8.2from
Conversation
4 tasks
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.2 #930 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 126 126
Lines 7364 7366 +2
=======================================
+ Hits 7144 7146 +2
Misses 220 220 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #919 to
8.2.Note
Medium Risk
Touches tiered-index concurrency by adding locking around sub-index debug-info access; low functional impact but mistakes could cause contention or deadlocks under background indexing.
Overview
Prevents races when collecting tiered index debug output by acquiring
shared_locks onflatIndexGuardandmainIndexGuardbefore callingfrontendIndex->debugInfoIterator()andbackendIndex->debugInfoIterator().Locks are scoped per sub-index (instead of held across both calls) to keep the critical sections small while still making debug-info generation safe during background indexing.
Reviewed by Cursor Bugbot for commit 6e89436. Bugbot is set up for automated code reviews on this repo. Configure here.