Skip to content

feat: PARSER-64 add MDX and 5 image file types to FileType enum #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dimitrystd wants to merge 1 commit into
base: 2.x
Choose a base branch
from
+78 −0
Open

feat: PARSER-64 add MDX and 5 image file types to FileType enum #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions smartling-files-api/src/main/java/com/smartling/api/files/v2/pto/FileType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ public enum FileType
INDD("application/octet-stream", false), // Adobe InDesign Document
VSDX("application/octet-stream", false), // Microsoft Visio Drawing
VSDM("application/octet-stream", false), // Microsoft Visio Macro-Enabled Drawing
MDX("text/plain", true), // MDX parser
IMAGE_PNG("image/png", false), // PNG image
IMAGE_JPG("image/jpeg", false), // JPG image
IMAGE_WEBP("image/webp", false), // WebP image
IMAGE_GIF("image/gif", false), // GIF image
IMAGE_BMP("image/bmp", false), // BMP image
;
private final String identifier;
private final String mimeType;
Expand Down
72 changes: 72 additions & 0 deletions smartling-files-api/src/test/java/com/smartling/api/files/v2/pto/FileTypeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
package com.smartling.api.files.v2.pto;

import org.junit.Test;

import static org.junit.Assert.*;

public class FileTypeTest
{
@Test
public void mdx_hasCorrectMimeTypeAndIsTextFormat()
{
assertEquals("text/plain", FileType.MDX.getMimeType());
assertTrue(FileType.MDX.isTextFormat());
}

@Test
public void imagePng_hasCorrectMimeTypeAndIsNotTextFormat()
{
assertEquals("image/png", FileType.IMAGE_PNG.getMimeType());
assertFalse(FileType.IMAGE_PNG.isTextFormat());
}

@Test
public void imageJpg_hasCorrectMimeTypeAndIsNotTextFormat()
{
assertEquals("image/jpeg", FileType.IMAGE_JPG.getMimeType());
assertFalse(FileType.IMAGE_JPG.isTextFormat());
}

@Test
public void imageWebp_hasCorrectMimeTypeAndIsNotTextFormat()
{
assertEquals("image/webp", FileType.IMAGE_WEBP.getMimeType());
assertFalse(FileType.IMAGE_WEBP.isTextFormat());
}

@Test
public void imageGif_hasCorrectMimeTypeAndIsNotTextFormat()
{
assertEquals("image/gif", FileType.IMAGE_GIF.getMimeType());
assertFalse(FileType.IMAGE_GIF.isTextFormat());
}

@Test
public void imageBmp_hasCorrectMimeTypeAndIsNotTextFormat()
{
assertEquals("image/bmp", FileType.IMAGE_BMP.getMimeType());
assertFalse(FileType.IMAGE_BMP.isTextFormat());
}

@Test
public void lookup_findsNewEntriesBySnakeCaseName()
{
assertEquals(FileType.MDX, FileType.lookup("MDX"));
assertEquals(FileType.IMAGE_PNG, FileType.lookup("IMAGE_PNG"));
assertEquals(FileType.IMAGE_JPG, FileType.lookup("IMAGE_JPG"));
assertEquals(FileType.IMAGE_WEBP,FileType.lookup("IMAGE_WEBP"));
assertEquals(FileType.IMAGE_GIF, FileType.lookup("IMAGE_GIF"));
assertEquals(FileType.IMAGE_BMP, FileType.lookup("IMAGE_BMP"));
}

@Test
public void lookup_findsNewEntriesByCamelCaseName()
{
assertEquals(FileType.MDX, FileType.lookup("mdx"));
assertEquals(FileType.IMAGE_PNG, FileType.lookup("imagePng"));
assertEquals(FileType.IMAGE_JPG, FileType.lookup("imageJpg"));
assertEquals(FileType.IMAGE_WEBP, FileType.lookup("imageWebp"));
assertEquals(FileType.IMAGE_GIF, FileType.lookup("imageGif"));
assertEquals(FileType.IMAGE_BMP, FileType.lookup("imageBmp"));
}
}