use previous version of symfony cache (WP-996)#612
Merged
vsolovei-smartling merged 1 commit intomasterfrom Apr 17, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| $filesCopied = 0; | ||
| $filesMissing = 0; | ||
|
|
||
| foreach (new RecursiveIteratorIterator( |
There was a problem hiding this comment.
this is iterator that iterates over iterators? looks like 'pimp my ride' :)
ykorobov-smartling
approved these changes
Apr 17, 2026
Comment on lines
+46
to
+51
| // Copy classmap files that are present in inc/third-party but absent from inc/lib. | ||
| // The namespacer skips namespace-less files (e.g. ValueWrapper.php), leaving them missing | ||
| // in inc/lib even though the generated autoloader still expects them. | ||
| $libDir = __DIR__ . '/inc/lib'; | ||
| $thirdPartyDir = __DIR__ . '/inc/third-party'; | ||
| $prefix = 'smartling-connector-'; |
Contributor
There was a problem hiding this comment.
How does this file work? is it some kind of "migration"? does it run only when user updates the plugin?
Contributor
Author
There was a problem hiding this comment.
Yes, this runs before release
PavelLoparev
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've ran into a similar issue that is likely related to symfony/symfony#46477. Two fixes: fix-double-namespace now includes an attempt to copy the unprocessed file to their namespaced location. The real fix is downgrading the symfony cache package to the previous major version to avoid an unprocessable file in docker environments.