Skip to content

upgrade formatter to ruff#583

Open
svij-sc wants to merge 2 commits intomainfrom
svij/migrate_to_using_ruff
Open

upgrade formatter to ruff#583
svij-sc wants to merge 2 commits intomainfrom
svij/migrate_to_using_ruff

Conversation

@svij-sc
Copy link
Copy Markdown
Collaborator

@svij-sc svij-sc commented Apr 10, 2026

Scope of work done

Ran new formatter here: #584

make check_format_py Performance Comparison

┌─────────────────────────────────┬───────┬──────────────┬─────────┐
│            Operation            │  Old  │     Ruff     │ Speedup │
├─────────────────────────────────┼───────┼──────────────┼─────────┤
│ check_format_py (read-only)     │ 6.0s  │ 0.32s (warm) │ 18.7x   │
├─────────────────────────────────┼───────┼──────────────┼─────────┤
│ format_py (modifying 450 files) │ 5.89s │ 0.46s        │ 12.8x   │
└─────────────────────────────────┴───────┴──────────────┴─────────┘

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: YES

uv run autoflake --check --config pyproject.toml ${PYTHON_DIRS}
uv run isort --check-only --settings-path=pyproject.toml ${PYTHON_DIRS}
uv run black --check --config=pyproject.toml ${PYTHON_DIRS}
uv run ruff check --config pyproject.toml ${PYTHON_DIRS}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ what's the difference between ruff check and ruff format?

Copy link
Copy Markdown
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants