fix: Launchers - Kubernetes - Jobs - Fixed LaunchedKubernetesJob.ended_at plus Set ExecutionNode.ended_at when SYSTEM_ERROR occurs in Orchestrator#200
Merged
yuechao-qin merged 1 commit intomasterfrom Apr 9, 2026
Conversation
Collaborator
Author
Ark-kun
approved these changes
Apr 9, 2026
Ark-kun
changed the title
ended_at and Complete statusended_at
Ark-kun
changed the title
ended_at
Ark-kun
changed the title
Ark-kun
changed the title
LaunchedKubernetesJob.ended_at plus Set ExecutionNode.ended_at when SYSTEM_ERROR occurs in Orchestrator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Closes https://github.com/Shopify/oasis-frontend/issues/542
Fixed Kubernetes job completion detection and added missing timestamp for failed container executions.
What changed?
ended_atmethod to properly detect when jobs finishended_attimestamp assignment when marking container executions asSYSTEM_ERRORin the orchestratorWhy make this change?
The Kubernetes API uses "Complete" rather than "Succeeded" as the condition type for finished jobs, so the previous code was likely not detecting job completions correctly. Additionally, failed executions were missing proper timestamp tracking, which is important for monitoring and debugging execution lifecycles.