Introduce _inter and _intra arrangement variants#723
Draft
frankmcsherry wants to merge 3 commits intoTimelyDataflow:master-nextfrom
Draft
Introduce _inter and _intra arrangement variants#723frankmcsherry wants to merge 3 commits intoTimelyDataflow:master-nextfrom
_inter and _intra arrangement variants#723frankmcsherry wants to merge 3 commits intoTimelyDataflow:master-nextfrom
Conversation
98da6cc to
1a0b84c
Compare
1a0b84c to
02cbc8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rework of #687 which means to demonstrate how one can use timely's
FrontierInterestto reduce the volume of scheduling that hits various operators. It reworksTraceAgentas two typesTraceIntraandTraceInter, the former more efficient to schedule but not shareable across dataflows, and the latter busier to schedule and shareable across dataflows. The distinction is that the latter needs to be able to mirror the frontier into the other dataflow explicitly, as progress tracking does not span dataflows, and to do this it needs to be continually rescheduled as its frontiers evolve.At the moment, there are mixed defaults of
TraceIntrafrom arrangements with_intervariants to produceTraceInterversions, andTraceInterfromreduce_tracewhich probably wants the same treatment as the arrangement functions.There is an additional question about which other operators should gain
FrontierInterest::IfCapability.reduce_traceseems like a good candidate. It is very analogous toarrange_core.join_traceswould be great, but there is a catch: it uses its frontiers to relax logical compaction in the other inputs. This is a non-problem forreduce_trace, because in the absence of further inputs (which prompt scheduling) there is nothing to do. Butjoin_tracescould have one frontier advance and the other not, and it could hypothetically unlock further compaction. I'm not certain it is a problem, by analogy toreduce_trace: if there's no data from either of them, what compaction is there to perform? But it is a bit tenuous.half_joinalso needs some thought. It also relaxes frontiers, and it does receive batch inputs from the trace (for scheduling), even though it ignores them. So potentially fine for the same reasons.Each of these are subtle though, and trace compaction is something I've gotten wrong before.