Add workflow for automatic rebase.

[DaniilKl]

No description provided.

[DaniilKl]

I am not sure why the actions launched the rebase.sh. This workflow is set up to be launched only when called by another workflow 😕 .

[DaniilKl]

I am not sure why the actions launched the rebase.sh. This workflow is set up to be launched only when called by another workflow 😕 .

It seems it was just an automatic check of the correctness of the rebase.yml, not the actual execution of the rebase.yml.

[DaniilKl]

I will have to add a few diagrams here, hence, switching to draft.

[DaniilKl]

I will have to add a few diagrams here, hence, switching to draft.

Moving to "Ready for review" now, I will consider adding the diagrams to TrenchBoot docs instead, as the diagrams will describe an entire CI/CD infrastructure for automatic rebasing in TrenchBoot organization.

This seems to be a good place: https://trenchboot.org/dev-docs/ .

[m-iwanicki]

Wouldn't you want the same ref as this workflow was called with?

[DaniilKl]

No I do not see a reason, unless there is a custom change to the rebase.sh that should be tested. But I have not found the way to redirect to the reusable workflow the ref it was called from. Because the reusable workflow inherits all the environment variables from the parent workflow (such as, for example github.sha, etc.). So for me the only way here is to use inputs to tell the reusable workflow about it, but I do not want to create yet another input just for that.

[m-iwanicki]

You are right, I got a little confused with how this would work with reusable workflow (and noticed there are GitHub issues related to exactly this)

[m-iwanicki]

No I do not see a reason, unless there is a custom change to the rebase.sh

I can't test it as rebase.sh doesn't exist on master currently :(

[DaniilKl]

I have unresolved this thread, as it seems I have found the solution: https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#example-usage-of-job-context-workflow-identity .

[DaniilKl]

I will need to do a squash at the end.

[DaniilKl]

I have found another corner case: 9501536 .

[m-iwanicki]

Check if at least 2 positional args were passed otherwise it will fail e.g.:

$1: unbound variable
$2: unbound variable

[DaniilKl]

8a88744

[m-iwanicki]

-if [[ "${#POSITIONAL_ARGS[@]}" -ne "2" ]]; then
+if [[ "${#POSITIONAL_ARGS[@]}" -lt "2" ]]; then

As we can have 3 or 4 arguments. This check is just to print some more meaningful error than unbound variable

[m-iwanicki]

I think we should deal with return code 5 (nothing to rebase). I don't think failing job (red x) would look good. I think in that case rest of the jobs should be skipped