Open
Conversation
* if no search index exists in mongo, one is created * if the fields of the existing search index in mongo do not match the current model, the existing search index is updated
* the academic calendars are now uploaded with an additional url field containing the box url for the calendar * bugfix: fixed past selector so that the links are extracted correctly and completely Co-authored-by: SuchDominion shijiand2022@gmail.com
Contributor
Author
|
The bug with the past selector was that it was simply a duplicate of the future selector. Now, the past selector selects all the links in both div elements for the past section. This fix resolves the issue that we were having with duplicate links in the csv in the scraping phase which led to duplicates in the json in the parsing stage. Now, all the calendars should be there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #158