refactor: Remove exceptions from Network Spawn Manager#3933
Open
noellie-velez wants to merge 7 commits intodevelop-2.0.0from
Open
refactor: Remove exceptions from Network Spawn Manager#3933noellie-velez wants to merge 7 commits intodevelop-2.0.0from
noellie-velez wants to merge 7 commits intodevelop-2.0.0from
Conversation
noellie-velez
commented
Apr 7, 2026
noellie-velez
commented
Apr 7, 2026
noellie-velez
commented
Apr 7, 2026
noellie-velez
commented
Apr 7, 2026
com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Apr 7, 2026
com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Apr 7, 2026
noellie-velez
commented
Apr 7, 2026
com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Apr 7, 2026
com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Apr 7, 2026
com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Apr 7, 2026
com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Apr 7, 2026
com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Apr 7, 2026
com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Apr 7, 2026
com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Apr 7, 2026
com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
NoelStephensUnity
approved these changes
Apr 8, 2026
Member
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
The only suggestion I have is adding a changelog entry for this PR before merging it.
The rest looks great to me!
👍
| // In distributed authority mode, we send a single message that is broadcasted to all clients | ||
| // that will be shown the object (i.e. 1 message to service that then broadcasts that to the | ||
| // targeted clients). When using a DAHost, we skip this and send like we do in client-server | ||
| // In distributed authority mode, we send a single message to the service, |
Member
There was a problem hiding this comment.
Nice clean up of this comment!
😻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Remove exceptions from Network Spawn Manager
Jira ticket
MTT-14791
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports