[v0.54.0]fix(tests): fix flaky tests#260
Merged
openshift-merge-bot[bot] merged 2 commits intoViaQ:v0.54.0-rhfrom Apr 22, 2026
Merged
[v0.54.0]fix(tests): fix flaky tests#260openshift-merge-bot[bot] merged 2 commits intoViaQ:v0.54.0-rhfrom
openshift-merge-bot[bot] merged 2 commits intoViaQ:v0.54.0-rhfrom
Conversation
…test Backport upstream fix (vectordotdev#24957) for a race condition in run_file_source test helper. When using Unfinalized acking mode, the default Delivered status on drop leaked checkpoint writes, causing the second run to skip re-reading the file. Use EventStatus::Rejected for Unfinalized mode so events are finalized but checkpoints are NOT updated, eliminating the race condition. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add yield_now() after dropping the buffer writer to allow the background finalizer task to release its Arc<Ledger> and the lock file before attempting to reopen the buffer. Without this, a race condition can cause LedgerLockAlreadyHeld errors when the finalizer task hasn't exited before the new buffer is created. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vparfonov
changed the title
vparfonov
changed the title
Author
|
/assign @jcantrill |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, vparfonov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
file_start_position_server_restart_unfinalizedtest, by backport upstream fix (fix(dev): make file source tests not flaky vectordotdev/vector#24957) for a race condition inrun_file_sourcetest helperinitial_size_correct_with_multieventstest, with addsyield_now()after dropping the buffer writer