fix: encode public key in signer URL to ensure proper formatting#3
Open
stevensf1998 wants to merge 1 commit intoVirtual-Protocol:mainfrom
Open
fix: encode public key in signer URL to ensure proper formatting#3stevensf1998 wants to merge 1 commit intoVirtual-Protocol:mainfrom
stevensf1998 wants to merge 1 commit intoVirtual-Protocol:mainfrom
Conversation
andrew-virtuals
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: a single change to URL construction in the signer setup flow, only affecting how the
publicKeyquery parameter is formatted.Overview
Fixes the signer approval link generation by URL-encoding the
publicKeyquery parameter (viaencodeURIComponent) inrunAddSignerFlow, preventing malformed URLs when the key contains characters that need escaping.Reviewed by Cursor Bugbot for commit 8d142c3. Bugbot is set up for automated code reviews on this repo. Configure here.