Skip to content

style(Authoring Tool): Organize node advanced using tabs#2306

Merged
hirokiterashima merged 1 commit intodevelopfrom
node-advanced-settings-tabs-and-dialog
Apr 16, 2026
Merged

style(Authoring Tool): Organize node advanced using tabs#2306
hirokiterashima merged 1 commit intodevelopfrom
node-advanced-settings-tabs-and-dialog

Conversation

@hirokiterashima
Copy link
Copy Markdown
Member

Also launch in a dialog

Changes

  • Use tabs to organize the different sections in the node advanced editing page. Before, they were buttons that show/hide the sections
  • Open the editing page in a dialog. Before, this took the user to a new route.

Test

  • Above works as described

@hirokiterashima hirokiterashima self-assigned this Apr 16, 2026
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Apr 16, 2026
@qltysh
Copy link
Copy Markdown

qltysh bot commented Apr 16, 2026

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (8)

RatingFile% DiffUncovered Line #s
New Coverage rating: F
...ced/constraint/node-advanced-constraint-authoring.component.ts25.0%28-33
New Coverage rating: F
...l/node/advanced/json/node-advanced-json-authoring.component.ts16.7%22-50
New Coverage rating: A
...d/node-advanced-authoring/node-advanced-authoring.component.ts100.0%
New Coverage rating: A
...e5/authoringTool/node/editRubric/edit-node-rubric.component.ts80.0%15
New Coverage rating: F
...l/node/advanced/path/node-advanced-path-authoring.component.ts50.0%76-79
New Coverage rating: F
.../authoringTool/node/node-authoring/node-authoring.component.ts100.0%
New Coverage rating: A
...it-node-advanced-button/edit-node-advanced-button.component.ts92.3%22
New Coverage rating: B
.../advanced/general/node-advanced-general-authoring.component.ts100.0%
Total64.6%
🤖 Increase coverage with AI coding...
In the `node-advanced-settings-tabs-and-dialog` branch, add test coverage for this new code:

- `src/assets/wise5/authoringTool/components/edit-node-advanced-button/edit-node-advanced-button.component.ts` -- Line 22
- `src/assets/wise5/authoringTool/node/advanced/constraint/node-advanced-constraint-authoring.component.ts` -- Line 28-33
- `src/assets/wise5/authoringTool/node/advanced/json/node-advanced-json-authoring.component.ts` -- Line 22-50
- `src/assets/wise5/authoringTool/node/advanced/path/node-advanced-path-authoring.component.ts` -- Line 76-79
- `src/assets/wise5/authoringTool/node/editRubric/edit-node-rubric.component.ts` -- Line 15

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review April 16, 2026 14:50
@hirokiterashima hirokiterashima merged commit 88ecf2e into develop Apr 16, 2026
4 checks passed
@hirokiterashima hirokiterashima deleted the node-advanced-settings-tabs-and-dialog branch April 16, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant