fix: regognize EUPL as GPL compatible license#1263
fix: regognize EUPL as GPL compatible license#1263Menrath wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
1dc226e to
a0d1de1
Compare
|
@ernilambar Thanks for pointing out the other PR, I adjusted this PR accordingly. |
7b0e8ba to
65274a5
Compare
|
Hello, you need to fix the code for the tests... |
|
@davidperezgar I would need to fix more of the code, first normalizing and then validating is just not safe. Just EUPL is no guarantee that it is GPL compatible. But EUPL-1.1 or EUPL-1.2 is. But maybe this detail is not that important in this case. |
|
Tests pass now. But note that a former test changed in c752740 |
| @@ -0,0 +1,12 @@ | |||
| <?php | |||
| /** | |||
| * Plugin Name: Test Plugin with WTFPL License | |||
There was a problem hiding this comment.
| * Plugin Name: Test Plugin with WTFPL License | |
| * Plugin Name: Test Plugin with EUPL License |
| /** | ||
| * Plugin Name: Test Plugin with WTFPL License | ||
| * Plugin URI: https://wordpress.org/plugins/test-plugin/ | ||
| * Description: Test plugin for WTFPL license validation. |
There was a problem hiding this comment.
| * Description: Test plugin for WTFPL license validation. | |
| * Description: Test plugin for EUPL license validation. |
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This looks unrelated change.
fixes #1262