Skip to content

fix: regognize EUPL as GPL compatible license#1263

Open
Menrath wants to merge 3 commits intoWordPress:trunkfrom
Menrath:patch-1
Open

fix: regognize EUPL as GPL compatible license#1263
Menrath wants to merge 3 commits intoWordPress:trunkfrom
Menrath:patch-1

Conversation

@Menrath
Copy link
Copy Markdown

@Menrath Menrath commented Apr 16, 2026

fixes #1262

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 16, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Menrath <andremenrath@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: ernilambar <nilambar@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar
Copy link
Copy Markdown
Member

@Menrath Thanks for the PR. You can take earlier merged PR for adding new license and its related PHP unit tests. #1158

@Menrath Menrath force-pushed the patch-1 branch 2 times, most recently from 1dc226e to a0d1de1 Compare April 16, 2026 18:27
@Menrath
Copy link
Copy Markdown
Author

Menrath commented Apr 16, 2026

@ernilambar Thanks for pointing out the other PR, I adjusted this PR accordingly.

@Menrath Menrath force-pushed the patch-1 branch 2 times, most recently from 7b0e8ba to 65274a5 Compare April 16, 2026 19:31
@davidperezgar
Copy link
Copy Markdown
Member

davidperezgar commented Apr 16, 2026

Hello, you need to fix the code for the tests...

@Menrath
Copy link
Copy Markdown
Author

Menrath commented Apr 16, 2026

@davidperezgar I would need to fix more of the code, first normalizing and then validating is just not safe.

Just EUPL is no guarantee that it is GPL compatible. But EUPL-1.1 or EUPL-1.2 is. But maybe this detail is not that important in this case.

@Menrath
Copy link
Copy Markdown
Author

Menrath commented Apr 16, 2026

Tests pass now. But note that a former test changed in c752740

@@ -0,0 +1,12 @@
<?php
/**
* Plugin Name: Test Plugin with WTFPL License
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Plugin Name: Test Plugin with WTFPL License
* Plugin Name: Test Plugin with EUPL License

/**
* Plugin Name: Test Plugin with WTFPL License
* Plugin URI: https://wordpress.org/plugins/test-plugin/
* Description: Test plugin for WTFPL license validation.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Description: Test plugin for WTFPL license validation.
* Description: Test plugin for EUPL license validation.

}
}
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks unrelated change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EUPL-1.2 is not recognized as compatible license

3 participants