Skip to content

Fix load non flat table #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aalkin merged 2 commits into from
Apr 17, 2026
Merged

Fix load non flat table #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c173449
fix backwards compability
jesgum Apr 17, 2026
2ffaaec
nicer comment
jesgum Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ALICE3/Core/FlatTrackSmearer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
void TrackSmearer::setWhatEfficiency(int val)
{
// FIXME: this really should be an enum
if (val > 2) {

Check failure on line 77 in ALICE3/Core/FlatTrackSmearer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
throw framework::runtime_error_f("getLUTEntry: unknown efficiency type %d", mWhatEfficiency);
}
mWhatEfficiency = val;
Expand All @@ -93,22 +93,23 @@
return false;
}

std::ifstream lutFile(filename, std::ifstream::binary);
if (!lutFile.is_open()) {
throw framework::runtime_error_f("Cannot open LUT file: %s", filename);
}

LOGF(info, "Loading %s LUT file: '%s'", getParticleName(pdg), filename);
const std::string localFilename = o2::fastsim::GeometryEntry::accessFile(filename, "./.ALICE3/LUTs/", mCcdbManager, 10);

std::ifstream lutFile(localFilename, std::ifstream::binary);
if (!lutFile.is_open()) {
throw framework::runtime_error_f("Cannot open LUT file: %s", localFilename);
}

try {
auto header = FlatLutData::PreviewHeader(lutFile, localFilename.c_str());
mLUTData[ipdg] = FlatLutData::loadFromFile(lutFile, localFilename.c_str());

// Validate header
auto header = mLUTData[ipdg].getHeader();
if (header.pdg != pdg && !checkSpecialCase(pdg, header)) {
LOGF(error, "LUT header PDG mismatch: expected %d, got %d; not loading", pdg, header.pdg);
return false;
}
mLUTData[ipdg] = FlatLutData::loadFromFile(lutFile, localFilename.c_str());
} catch (framework::RuntimeErrorRef ref) {
LOGF(error, "%s", framework::error_from_ref(ref).what);
return false;
Expand Down
Loading