新增跨平台异步IO模块 by actboy168 · Pull Request #64 · actboy168/bee.lua

actboy168 · 2026-04-14T13:15:58Z

No description provided.

gemini-code-assist

Code Review

This pull request introduces a comprehensive cross-platform asynchronous I/O library for the bee.lua project, implementing backends for Windows (IOCP), Linux (io_uring and epoll), and macOS/BSD (GCD and kqueue). The implementation includes specialized stream buffers and Lua bindings to expose these capabilities. Critical feedback identifies a use-after-free vulnerability in the BSD backend's cancellation logic where kqueue events are not properly deregistered. Additional improvements are suggested to optimize memory usage in the macOS backend by avoiding heap allocations in poll submissions, clarify the behavior of the io_uring cancellation stub, and clean up unreachable code within the Lua binding's completion iterator.

Copilot

Pull request overview

该 PR 引入 bee.async 跨平台异步 I/O 模块，并补齐 Lua 绑定、类型注解、测试与性能对比基准，用于在 Windows/macOS/Linux/BSD 上提供统一的异步 socket / 文件 I/O / fd poll API。

Changes:

新增 bee.async Lua 模块与 C++ 后端实现（Windows IOCP、macOS GCD、Linux io_uring/epoll、BSD kqueue）。
新增 ring buffer（readbuf）与 per-stream write buffer（writebuf）并在 Lua 侧暴露 submit/readline/backpressure 相关接口。
新增单元测试与 benchmark（epoll vs async），并更新 test/bench 启动脚本与构建选择开关。

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
test/test_async.lua	新增 async 模块的功能性测试（读写/accept/connect/文件IO/poll/backpressure/close 等）。
test/test.lua	将 `test_async` 纳入测试入口。
test.lua	支持 `-bench` 路径：在 benchmark/ 下运行 `bench.lua`，否则运行单元测试。
meta/async.lua	新增 `bee.async` 的 Lua 类型注解与 API 说明。
compile/common.lua	增加可选后端选择（macOS kqueue / Linux epoll）相关的源文件排除与宏定义。
binding/lua_socket.cpp	暴露 socket fd / endpoint 的辅助函数，供 async 绑定复用。
binding/lua_async.cpp	新增 `bee.async` Lua 绑定：提交 I/O、completion 迭代器、readbuf/writebuf 实现。
benchmark/net_epoll.lua	新增 epoll 版网络抽象用于性能对比。
benchmark/net_async.lua	新增 async 版网络抽象用于性能对比。
benchmark/ltask.lua	新增轻量任务调度器（用于 benchmark 驱动）。
benchmark/bench.lua	新增基准：epoll/async × rtt/pipeline 对比。
bee/async/write_buf.h	新增 writebuf 数据结构（队列、HWM、in-flight 状态）。
bee/async/ring_buf.h	新增 ring buffer（readbuf）实现：commit/consume/find/readline 支持。
bee/async/async_win.h	新增 Windows IOCP 后端接口声明（含文件/accept/connect/poll 等）。
bee/async/async_win.cpp	新增 Windows IOCP 后端实现（AcceptEx/ConnectEx、同步完成队列等）。
bee/async/async_uring_linux.h	新增 Linux io_uring 后端声明。
bee/async/async_uring_linux.cpp	新增 Linux io_uring 后端实现（自带 UAPI 定义、mmap ring、submit/harvest）。
bee/async/async_types.h	新增跨后端统一的 completion 状态/操作类型定义。
bee/async/async_osx.h	新增 macOS GCD 后端声明（dispatch source + semaphore）。
bee/async/async_osx.cpp	新增 macOS GCD 后端实现（按 fd 复用 read/write source + one-shot accept/connect/poll）。
bee/async/async_epoll_linux.h	新增 Linux epoll 后端声明（fd_state + pending_op）。
bee/async/async_epoll_linux.cpp	新增 Linux epoll 后端实现（arm/disarm、event drain、sync completions）。
bee/async/async_bsd.h	新增 BSD kqueue 后端声明（pending_op set + kevent 注册）。
bee/async/async_bsd.cpp	新增 BSD kqueue 后端实现（EV_ONESHOT、drain、cancel/stop）。
bee/async/async.h	新增跨平台 async 抽象与平台选择 include。
bee/async/async.cpp	新增后端工厂：Linux 优先 io_uring，不可用则回退 epoll；其他平台创建对应实现。

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…le_read completions Agent-Logs-Url: https://github.com/actboy168/bee.lua/sessions/27a22d9e-eaf9-4907-a4c1-00bc1f532a4c Co-authored-by: actboy168 <1836844+actboy168@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

actboy168 · 2026-04-14T14:16:04Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a cross-platform asynchronous I/O library for the Bee project, supporting Linux (io_uring/epoll), macOS (GCD), and Windows (IOCP). The implementation includes core async interfaces, platform-specific backends, and Lua bindings. My review identified several critical issues: a use-after-free vulnerability in file writing due to missing Lua object pinning, potential infinite loops in write completion handling across multiple backends, memory leaks in the Lua completion iterator, and a potential deadlock scenario when cancelling I/O operations.

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

actboy168 · 2026-04-15T02:43:30Z

/gemini review

gemini-code-assist

Code Review

This pull request implements a cross-platform asynchronous I/O library for Lua, providing backends for Windows (IOCP), Linux (io_uring/epoll), and macOS/BSD (GCD/kqueue). The review identified a critical memory safety bug in the Windows backend where stack-allocated WSABUF structures are used for asynchronous operations. Additionally, the cancel implementation across multiple platforms needs to generate completion events to avoid leaking Lua references. Other feedback includes a request for functional cancellation in the io_uring backend and a minor formatting correction.

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

新增跨平台异步IO模块

4e38062

actboy168 requested a review from Copilot April 14, 2026 13:19

Copilot started reviewing on behalf of actboy168 April 14, 2026 13:19 View session

gemini-code-assist bot reviewed Apr 14, 2026

View reviewed changes

Comment thread bee/async/async_bsd.cpp

Comment thread bee/async/async_osx.h Outdated

Comment thread bee/async/async_osx.cpp

Comment thread bee/async/async_uring_linux.cpp

Comment thread binding/lua_async.cpp Outdated

Copilot AI reviewed Apr 14, 2026

View reviewed changes

actboy168 and others added 2 commits April 14, 2026 21:44

Update meta/async.lua

b344d13

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

refactor: 简化 read 逻辑并优化 buf_unpin 与 commit 调用

446d656

Copilot started work on behalf of actboy168 April 14, 2026 13:46 View session

Copilot AI and others added 2 commits April 14, 2026 13:48

fix: expand poll/wait return type annotation to include string for fi…

6e1152e

…le_read completions Agent-Logs-Url: https://github.com/actboy168/bee.lua/sessions/27a22d9e-eaf9-4907-a4c1-00bc1f532a4c Co-authored-by: actboy168 <1836844+actboy168@users.noreply.github.com>

Update bee/async/async_uring_linux.cpp

258cf83

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot finished work on behalf of actboy168 April 14, 2026 13:49

actboy168 and others added 7 commits April 14, 2026 21:51

refactor: 简化异步IOURING初始化逻辑并明确内核特性要求

bb8518a

refactor: 动态设置 io_uring_enter 的 arg 大小以提升灵活性

a9330ff

Update test/test_async.lua

185b2df

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

refactor: 优化epoll操作前置校验与防重复提交

a1c82ac

docs: 更新 cancel 函数注释说明为空操作及取消要求

41eaeb1

feat: 新增 op_filter 并完善 kqueue 事件取消防 use-after-free

77f0d0e

refactor: 移除 pending_op 结构体及相关动态分配逻辑

023b9e3

actboy168 requested a review from Copilot April 14, 2026 14:10

Copilot started reviewing on behalf of actboy168 April 14, 2026 14:12 View session

gemini-code-assist bot reviewed Apr 14, 2026

View reviewed changes

Comment thread binding/lua_async.cpp Outdated

Comment thread bee/async/async_uring_linux.cpp

Comment thread bee/async/async_epoll_linux.cpp

Comment thread bee/async/async_bsd.cpp

Comment thread binding/lua_async.cpp

Comment thread bee/async/async.h

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread compile/common.lua

Comment thread bee/async/ring_buf.h Outdated

Comment thread bee/async/async_win.cpp

Comment thread bee/async/async_bsd.cpp

Comment thread binding/lua_async.cpp

Comment thread binding/lua_async.cpp

Comment thread meta/async.lua

actboy168 added 7 commits April 14, 2026 22:28

refactor: 修正环形缓冲区大小计算并兼容32/64位平台

8b684aa

refactor: 添加异步请求资源清理与缓冲区释放

4b5f638

refactor: 重构异步事件处理，增强虚假唤醒检测与重注册可靠性

40dace1

feat: 异步文件写入绑定buf防释放并完善错误处理

ca52017

refactor: 引入luaref机制重构异步IO引用管理

6aab683

refactor: 重构异步操作机制，改用 packed_id 统一管理请求与引用

addbfc1

refactor: 重构net_async读逻辑并统一常量与字段命名

4438893

feat: 新增异步读多缓冲区支持

9859340

actboy168 requested a review from Copilot April 15, 2026 00:57

Copilot started reviewing on behalf of actboy168 April 15, 2026 00:58 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread binding/lua_async.cpp Outdated

Comment thread bee/async/async_uring_linux.cpp

Comment thread bee/async/async_uring_linux.cpp Outdated

actboy168 and others added 5 commits April 15, 2026 09:05

feat: 新增异步分散读支持及 read/readv 双分支处理

aff593b

Update binding/lua_async.cpp

06703a1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

refactor: 统一将 io_uring 相关标识及结构体前缀由 UV__ 改为 BEE__

f1b304d

fix: 修正 io_uring_enter 重试条件并统一中断

0d413bc

feat: 新增 io_uring 超时处理及内部 timeout 类型支持

c17f000

actboy168 requested a review from Copilot April 15, 2026 02:43

Copilot started reviewing on behalf of actboy168 April 15, 2026 02:44 View session

gemini-code-assist bot reviewed Apr 15, 2026

View reviewed changes

Comment thread bee/async/async_win.cpp

Comment thread bee/async/async_bsd.cpp

Comment thread bee/async/async_epoll_linux.cpp

Comment thread bee/async/async_osx.cpp

Comment thread bee/async/async_uring_linux.cpp Outdated

Comment thread bee/async/async_uring_linux.cpp

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread bee/async/async_win.cpp

Comment thread bee/async/async_win.cpp

Comment thread meta/async.lua Outdated

actboy168 and others added 5 commits April 15, 2026 18:05

feat: 增强 Windows 异步操作支持，新增监听套接字与上下文更新

5edf2a6

Update meta/async.lua

ab6022b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

refactor: 优化 submit_write 实现，新增 sqe 获取与发送逻辑

c6af582

feat: 新增SO_UPDATE_ACCEPT/CONNECT_CONTEXT宏并移除mstcpip/mswsock依赖

55e23a6

refactor: 清理并统一 Windows 异步 IO 扩展函数引用

21a3ec1

actboy168 requested a review from Copilot April 15, 2026 14:40

Copilot started reviewing on behalf of actboy168 April 15, 2026 14:40 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread test/test_async.lua Outdated

Comment thread test/test_async.lua Outdated

Comment thread binding/lua_async.cpp

Comment thread binding/lua_async.cpp

actboy168 and others added 4 commits April 15, 2026 23:00

Update test/test_async.lua

e5ed2fb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: 修复wb_submit_all失败时资源泄漏与状态不一致问题

56958fe

fix: 修复 wait_completion 返回值并增加操作类型 op

29bffa4

refactor: 重构 wait_accept 签名并清理冗余 associate 调用

db4ab1d

actboy168 merged commit 0f8efd2 into master Apr 15, 2026
15 checks passed

actboy168 deleted the async-io branch April 15, 2026 15:59

Conversation

actboy168 commented Apr 14, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

actboy168 commented Apr 14, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

actboy168 commented Apr 15, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!