Skip to content

Add source branch and hide common target branches in PR dashboard#235

Open
kroeschl wants to merge 6 commits intoalejandro5042:masterfrom
kroeschl:source-branch
Open

Add source branch and hide common target branches in PR dashboard#235
kroeschl wants to merge 6 commits intoalejandro5042:masterfrom
kroeschl:source-branch

Conversation

@kroeschl
Copy link
Copy Markdown
Contributor

@kroeschl kroeschl commented Apr 24, 2024

Justification

When looking at the PR dashboard, I frequently want to see the name of the source branch for a given PR. I also almost never care about the target branch, because it's usually just main or master.

Implementation

Add the source branch to all PRs. Hide the target branch (and related text and icon) if it's main or master. Also abbreviate user branch names like users/kroeschl/foo to 👤/foo to save space in the dashboard. Update the README and update notification.

Testing

Viewed some PRs into main and some into and from not-main and not-user/... to verify rendering:
image
Also verified that the notification content renders well enough:
image

@alejandro5042
Copy link
Copy Markdown
Owner

alejandro5042 commented May 4, 2024

Hey! Thanks for this draft PR! Overall, I like it. Also, thanks for updating the popup.

I'm not sure about the rewriting the branch name--it would then display incorrect/misleading information. I'm down for shortening, but I'd want it to look different.

How about this?

👤/my-branch

@kroeschl
Copy link
Copy Markdown
Contributor Author

kroeschl commented May 6, 2024

How about this?

👤/my-branch

I like that idea. Something like this? Should we do something different for not-me? Or just not shorten branches for other users?
user-icon-branch

Or we could use to make it more obvious without needing to handle self vs other users differently.
image

@kroeschl kroeschl marked this pull request as ready for review April 16, 2026 16:09
@alejandro5042
Copy link
Copy Markdown
Owner

@kroeschl -- the more I think about it, the less I like rewriting the branch name. In the UI, it creates an "oh, gotcha" moment where the branch name you expect to see isn't the one that's displayed.

I do really like the idea of adding the source branch, though. Let's go with that! And iterate on the other topic later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants