-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@angular/cli): copy project config files to temp directory during ng update #32959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -155,6 +155,7 @@ export const SUPPORTED_PACKAGE_MANAGERS = { | |
| ignoreScriptsFlag: '--ignore-scripts', | ||
| ignorePeerDependenciesFlag: '--force', | ||
| configFiles: ['.npmrc'], | ||
| copyConfigFromProject: true, | ||
| getRegistryOptions: (registry: string) => ({ args: ['--registry', registry] }), | ||
| versionCommand: ['--version'], | ||
| listDependenciesCommand: ['list', '--depth=0', '--json=true', '--all=true'], | ||
|
|
@@ -180,6 +181,7 @@ export const SUPPORTED_PACKAGE_MANAGERS = { | |
| noLockfileFlag: '', | ||
| ignoreScriptsFlag: '--mode=skip-build', | ||
| configFiles: ['.yarnrc.yml', '.yarnrc.yaml'], | ||
| copyConfigFromProject: true, | ||
| getRegistryOptions: (registry: string) => ({ env: { YARN_NPM_REGISTRY_SERVER: registry } }), | ||
| versionCommand: ['--version'], | ||
| listDependenciesCommand: ['info', '--name-only', '--json'], | ||
|
|
@@ -208,6 +210,7 @@ export const SUPPORTED_PACKAGE_MANAGERS = { | |
| noLockfileFlag: '--no-lockfile', | ||
| ignoreScriptsFlag: '--ignore-scripts', | ||
| configFiles: ['.yarnrc', '.npmrc'], | ||
| copyConfigFromProject: true, | ||
| getRegistryOptions: (registry: string) => ({ args: ['--registry', registry] }), | ||
| versionCommand: ['--version'], | ||
| listDependenciesCommand: ['list', '--depth=0', '--json'], | ||
|
|
@@ -233,7 +236,10 @@ export const SUPPORTED_PACKAGE_MANAGERS = { | |
| noLockfileFlag: '--no-lockfile', | ||
| ignoreScriptsFlag: '--ignore-scripts', | ||
| ignorePeerDependenciesFlag: '--strict-peer-dependencies=false', | ||
| configFiles: ['.npmrc', 'pnpm-workspace.yaml'], | ||
| // Note: pnpm-workspace.yaml is intentionally excluded. Copying it to the | ||
| // temporary directory could cause pnpm to treat it as a workspace root. | ||
| configFiles: ['.npmrc'], | ||
| copyConfigFromProject: true, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Enabling
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only .npmrc is needed for registry settings. Added a comment explaining the exclusion. |
||
| getRegistryOptions: (registry: string) => ({ args: ['--registry', registry] }), | ||
| versionCommand: ['--version'], | ||
| listDependenciesCommand: ['list', '--depth=0', '--json'], | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.