Open
Conversation
Made a few major changes in the this PR all in support of providing an improved tserver page on the monitor. * Gave the RPC thread a consistent name across all server types. This was done to make the thread name findable in a metrics tag using a constant. * Setup a custom monitor metrics registry. This was done because it may not be safe to read from registry in another thread (see micrometer-metrics/micrometer#7417) AND more importantly to get step functionality where metrics like function counters show the delta for the last 30 seconds. * Refactored the SeversView code to be more flexible. It used to directly compute data from a a single metric. Now its easier to do arbitrary reductions on a collection of metrics for the data in a column. * Started collecting executor metrics on thread pools and used those to create some of the tserver columns in the monitor. Using the metrics requires looking for specific thread pool names in the tags. * Added a new meric to track scan errors. * Fixed some incorrect metrics types.
Contributor
Author
|
This is a screenshot of the updated tserver page. Notice the new rates, these will make sorting on data much easier. Before there were ever increasing counts which make sorting not as useful when some tsevers have been running for months and some just restarted. The rates are based on the last 30 seconds of count increments for each tserver this comes from the new registry. 
|
keith-turner
commented
Apr 22, 2026
| opts.parseArgs(applicationName, args); | ||
| var siteConfig = opts.getSiteConfiguration(); | ||
| final String newBindParameter = siteConfig.get(Property.RPC_PROCESS_BIND_ADDRESS); | ||
| final String newBindParameter = siteConfig.get(siteConfig |
Contributor
Author
There was a problem hiding this comment.
This is a bug found while testing this, need to pull this in to a separate PR and some script changes are also needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a few major changes in the this PR all in support of providing an improved tserver page on the monitor.