Follow-up fixes for double-encode trigger PR#64823
Open
jason810496 wants to merge 1 commit intoapache:mainfrom
Open
Follow-up fixes for double-encode trigger PR#64823jason810496 wants to merge 1 commit intoapache:mainfrom
jason810496 wants to merge 1 commit intoapache:mainfrom
Conversation
jason810496
requested review from
Lee-W,
uranusjr and
vatsrahul1001
and removed request for
XD-DENG and
ashb
Lee-W
reviewed
Apr 7, 2026
|
|
||
| pytest.importorskip("airflow.providers.apache.kafka") | ||
| from airflow.providers.apache.kafka.triggers.await_message import AwaitMessageTrigger | ||
| try: |
Member
There was a problem hiding this comment.
should we move it to provider test instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Address unresolved review comments from #64626
What
trigger.py: Add# to avoid circular import: Callbackto clarify the purpose of lazy importtest_encoders.py: Replace module-level pytest.importorskip with a try/except block so FileDeleteTrigger (non-Kafka) tests still run when the Kafka provider is not installed.test_collection.py: Move Trigger, encode_trigger, and BaseEventTrigger imports from inline test bodies to module scope.