Pipe: Refactor AirGap receiver with configurable payload size control#17443
Open
luoluoyuyu wants to merge 7 commits intoapache:masterfrom
Open
Pipe: Refactor AirGap receiver with configurable payload size control#17443luoluoyuyu wants to merge 7 commits intoapache:masterfrom
luoluoyuyu wants to merge 7 commits intoapache:masterfrom
Conversation
Introduce a dedicated AirGap receiver payload limit in the pipe config and enforce it before request buffer allocation, so oversized payloads are rejected early and memory pressure is bounded under malicious or malformed inputs. Made-with: Cursor
luoluoyuyu
changed the title
jt2594838
approved these changes
Apr 8, 2026
Comment on lines
95
to
105
| if (!socket.isClosed()) { | ||
| socket.close(); | ||
| } | ||
| } finally { | ||
| // session will be closed and removed here | ||
| PipeDataNodeAgent.receiver().thrift().handleClientExit(); | ||
| socket.close(); | ||
| if (!socket.isClosed()) { | ||
| socket.close(); | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Is the close above redundant?
Contributor
|
May add a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR