[Draft] Authenticated Received Chain - ARC-sealing#31
Draft
agrinchenko wants to merge 105 commits intoapache:masterfrom
Draft
[Draft] Authenticated Received Chain - ARC-sealing#31agrinchenko wants to merge 105 commits intoapache:masterfrom
agrinchenko wants to merge 105 commits intoapache:masterfrom
Conversation
Fix FWS is not trimmed correctly
- Use goals `single` instead of `attached` by the recommendation at http://maven.apache.org/plugins-archives/maven-assembly-plugin-2.5.5/attached-mojo.html
Following alphabetical order with groupId > artifactId
The JDKIM mailet has been moved into James server project
After removing the mailet (been moved to James), those libs are not necessary anymore.
Contributor
|
I have limited bandwith because of over-committing on another project. I will take time for a complete review of this work this weekend. |
Author
|
Thanks, Benoit! No rush.. |
chibenwa
reviewed
Oct 26, 2025
chibenwa
reviewed
Oct 26, 2025
Contributor
chibenwa
left a comment
chibenwa
left a comment
There was a problem hiding this comment.
I do think we could benefit from updating the documentation (src/site ?) for mentionning arc and dkim support + giving some little code examples.
I (tried to) refrain from doing too much code style related comments but I'd be happy, if you accept, to propose you a changeset to polish a bit this work (i'd PR your branch).
epinter
reviewed
Oct 26, 2025
epinter
reviewed
Oct 26, 2025
epinter
reviewed
Oct 26, 2025
- Added ARC validation outcome with details on the failure - Refactored logic such as `computeBTag` into separate methods - Added hard fail whenever multiple From headers detected - Rewrote tag extraction logic to do it all in one pass for efficiency - Simplified getTimeMeasure to use standard Java - Removed unnecessary Overrides
Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.26.0 to 3.27.7. - [Release notes](https://github.com/assertj/assertj/releases) - [Commits](assertj/assertj@assertj-build-3.26.0...assertj-build-3.27.7) --- updated-dependencies: - dependency-name: org.assertj:assertj-core dependency-version: 3.27.7 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Removed typos
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
|
Last comnit in the README is nice. I'll commit to do a review, likely next weekend. We shalll eventually merge this work upstream in james-jdkim. |
Author
Thanks! Sorry for the delays; I've been going through some changes lately, but all is good now. Waiting on your review. |
ieugen
changed the title
…ature b= is cryptographically invalid
…yptographically invalid
…chain structure is invalid. Also add cv_fail_i1_as_pass and cv_fail_i1_as_cv_fail tests: assert cv=fail when ARC-Seal cv= is invalid on first hop
…ature failures in a two-hop ARC chain
… Also add cv_pass_i2..i5 and cv_pass_i2_1_ams1_invalid tests
- Add ValiMail-derived AMS tag format validation coverage for whitespace around separators and trailing semicolons. Add a duplicate - ARC-Message-Signature i=1 ordering variant to ensure duplicate AMS instances are rejected regardless of header order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for ARC-sealing for review/comments/feedback. Work in progress.