Open
Conversation
JingsongLi
reviewed
Apr 15, 2026
| /// schema directory is missing or empty. | ||
| /// | ||
| /// Mirrors Java [SchemaManager.listAllIds()](https://github.com/apache/paimon/blob/release-1.3/paimon-core/src/main/java/org/apache/paimon/schema/SchemaManager.java). | ||
| pub async fn list_all_ids(&self) -> crate::Result<Vec<i64>> { |
Contributor
There was a problem hiding this comment.
Consider refactor load_latest_table_schema to reuse codes.
| let ids = self.list_all_ids().await?; | ||
| let mut schemas = Vec::with_capacity(ids.len()); | ||
| for id in ids { | ||
| schemas.push(self.schema(id).await?); |
Contributor
There was a problem hiding this comment.
For tables with many schema versions, parallel loading via futures::future::try_join_all would be faster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Mirrors Java SchemasTable: exposes
<table>$schemasas a DataFusion table provider listing all historical schema versions of a Paimon table, with 7 columns matching JavaSchemasTable.TABLE_TYPE.