[core] Avoid key bytes OOM in ClusteringFileRewriter.sortAndRewriteFile#7642
Merged
JingsongLi merged 3 commits intoapache:masterfrom Apr 14, 2026
Merged
[core] Avoid key bytes OOM in ClusteringFileRewriter.sortAndRewriteFile#7642JingsongLi merged 3 commits intoapache:masterfrom
JingsongLi merged 3 commits intoapache:masterfrom
Conversation
LsomeYeah
reviewed
Apr 14, 2026
| * Sort and rewrite unsorted file by clustering columns. Reads all KeyValue records, sorts them | ||
| * using an external sort buffer, and writes to new level-1 files. Checks the key index inline | ||
| * during writing to handle deduplication (FIRST_ROW skips duplicates, DEDUPLICATE marks old | ||
| * positions in DV) and updates the index without re-reading the output files. |
Contributor
There was a problem hiding this comment.
Doc seems to be not accurate. When rebuildIndex, the file now will be re-read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Avoid key bytes OOM in ClusteringFileRewriter.sortAndRewriteFile. Removing the in-memory List<byte[]> collectedKeys and the batchPutIndex method eliminates the unbounded memory accumulation.
Tests
Existing Tests.