Skip to content

refactor: Update generated models and adapt to them#704

Open
apify-service-account wants to merge 2 commits intomasterfrom
update-models-docs-pr-2398
Open

refactor: Update generated models and adapt to them#704
apify-service-account wants to merge 2 commits intomasterfrom
update-models-docs-pr-2398

Conversation

@apify-service-account
Copy link
Copy Markdown

@apify-service-account apify-service-account commented Apr 7, 2026

This PR updates the auto-generated Pydantic models based on OpenAPI specification changes in apify-docs PR #2398.

Summary

  • Regenerated _models.py from updated OpenAPI spec
  • Adapted resource clients to renamed/restructured models:
    • TaskOptionsOptionalRunOptions
    • ScheduleCreateActions → discriminated union in ScheduleCreate
    • EnvVarEnvVarRequest for create/update requests

@apify-service-account apify-service-account force-pushed the update-models-docs-pr-2398 branch 5 times, most recently from efceeae to cd29698 Compare April 8, 2026 11:29
@vdusek vdusek changed the title [TODO]: update generated models from apify-docs PR #2398 refactor: update generated models from apify-docs PR #2398 Apr 8, 2026
@vdusek vdusek changed the title refactor: update generated models from apify-docs PR #2398 refactor: Update generated models and adapt to them Apr 8, 2026
@vdusek vdusek requested review from Pijukatel and janbuchar April 8, 2026 11:44
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.81%. Comparing base (73164df) to head (316409f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
- Coverage   94.98%   94.81%   -0.17%     
==========================================
  Files          45       45              
  Lines        4405     4551     +146     
==========================================
+ Hits         4184     4315     +131     
- Misses        221      236      +15     
Flag Coverage Δ
integration 94.81% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@apify-service-account apify-service-account force-pushed the update-models-docs-pr-2398 branch from 5b2c477 to 39083ae Compare April 8, 2026 12:04
@apify-service-account apify-service-account force-pushed the update-models-docs-pr-2398 branch from 0c2810f to 5abcbb3 Compare April 8, 2026 13:19
Update imports and usages after model regeneration:
- TaskOptions → OptionalRunOptions (task.py, task_collection.py)
- ScheduleCreateActions removed, pass raw dicts to ScheduleCreate (schedule.py, schedule_collection.py)
- EnvVar → EnvVarRequest (actor_version.py, actor_version_collection.py)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants