Skip to content

feat(enums): add deprecated historical phosphor icon names to AtlanIcon#2432

Merged
cmgrote merged 3 commits intomainfrom
BLDX-1097
Apr 22, 2026
Merged

feat(enums): add deprecated historical phosphor icon names to AtlanIcon#2432
cmgrote merged 3 commits intomainfrom
BLDX-1097

Conversation

@cmgrote
Copy link
Copy Markdown
Collaborator

@cmgrote cmgrote commented Apr 22, 2026

Summary

  • Adds 11 @Deprecated enum constants to AtlanIcon for phosphor icon names that were renamed in older versions of the library
  • Prevents deserialization exceptions when reading pre-existing persisted data that still carries the old icon name strings
  • Also aligns the enum with the current frontend (@phosphor-icons/vue v2.2.1) — no icons are missing or extra beyond the intentional deprecated set

Deprecated names added

Deprecated constant Old value Replacement
PEDESTRIAN PhPedestrian PERSON (v1.3.1)
ACTIVITY PhActivity PULSE (v2.0.0)
CIRCLE_WAVY PhCircleWavy SEAL (v2.0.0)
CIRCLE_WAVY_CHECK PhCircleWavyCheck SEAL_CHECK (v2.0.0)
CIRCLE_WAVY_QUESTION PhCircleWavyQuestion SEAL_QUESTION (v2.0.0)
CIRCLE_WAVY_WARNING PhCircleWavyWarning SEAL_WARNING (v2.0.0)
FILE_DOTTED PhFileDotted FILE_DASHED (v2.0.0)
FILE_SEARCH PhFileSearch FILE_MAGNIFYING_GLASS (v2.0.0)
FOLDER_DOTTED PhFolderDotted FOLDER_DASHED (v2.0.0)
FOLDER_SIMPLE_DOTTED PhFolderSimpleDotted FOLDER_SIMPLE_DASHED (v2.0.0)
TEXT_BOLDER PhTextBolder TEXT_B (v2.0.0)

Test plan

  • Confirm existing unit tests pass (./gradlew test)
  • Verify that deserializing a JSON payload containing e.g. "PhCircleWavyWarning" resolves to the CIRCLE_WAVY_WARNING constant without exception

🤖 Generated with Claude Code

Adds 11 deprecated enum constants for icon names renamed across
phosphor-icons v1.x and v2.x, so pre-existing persisted values
deserialize without exceptions rather than failing at runtime.

v1.3.1: pedestrian → person
v2.0.0: activity → pulse, circle-wavy* → seal*, file-dotted →
  file-dashed, file-search → file-magnifying-glass, folder-dotted →
  folder-dashed, folder-simple-dotted → folder-simple-dashed,
  text-bolder → text-b

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
@cmgrote cmgrote added the bug Something isn't working label Apr 22, 2026
@cmgrote cmgrote enabled auto-merge April 22, 2026 09:49
@cmgrote cmgrote disabled auto-merge April 22, 2026 09:49
@cmgrote cmgrote enabled auto-merge April 22, 2026 09:59
@cmgrote cmgrote merged commit fe96a00 into main Apr 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant