Allow for parsing of errors involving nullable enums#241
Open
dmiller113 wants to merge 3 commits intomainfrom
Open
Allow for parsing of errors involving nullable enums#241dmiller113 wants to merge 3 commits intomainfrom
dmiller113 wants to merge 3 commits intomainfrom
Conversation
added 3 commits
March 13, 2026 12:18
Previously, when attempting to print errors for schemas that include nullable enums, the call of "leven" would error as null has no length. This commit changes the print function to only call for leven distance with nonnull values and also handle printing null values, as a simple join will only output ", ". BUG: [Issue-224](#224)
🦋 Changeset detectedLatest commit: 10461ef The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 67.43% 67.85% +0.42%
==========================================
Files 19 19
Lines 611 619 +8
Branches 106 110 +4
==========================================
+ Hits 412 420 +8
Misses 195 195
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
Issue #224
Changes
nullable enums.
printbehavior to allow for displayingnullas an allowed valueRovo Dev code review: Rovo Dev couldn't review this pull request
Upgrade to Rovo Dev Standard to continue using code review.