Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

Fix failing getUsernames test#2927

Merged
arjun-dureja merged 2 commits intomasterfrom
arjun/fix-getUsernames-test
Jan 22, 2026
Merged

Fix failing getUsernames test#2927
arjun-dureja merged 2 commits intomasterfrom
arjun/fix-getUsernames-test

Conversation

@arjun-dureja
Copy link
Copy Markdown
Collaborator

What changed? Why?

  • The getUsernames test was failing due to a conflict on master. This PR fixes it

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Jan 22, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
base-web Error Error Jan 22, 2026 9:06pm

Request Review

@arjun-dureja arjun-dureja marked this pull request as ready for review January 22, 2026 18:44
@arjun-dureja arjun-dureja merged commit f7a8b54 into master Jan 22, 2026
10 of 11 checks passed
@arjun-dureja arjun-dureja deleted the arjun/fix-getUsernames-test branch January 22, 2026 21:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants