fix(pypi): skip index lookups when all package overrides are specified#3710
Open
aignas wants to merge 1 commit intobazel-contrib:mainfrom
Open
Conversation
When index_url_overrides is provided for all packages, we no longer need to call the index at all. This improves performance and aligns with the expected behavior where overrides should be sufficient. Fixes bazel-contrib#3709
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the simpleapi_download logic to optimize package URL resolution when index_url_overrides are provided, alongside corresponding updates to the documentation and tests. However, the current implementation introduces a regression by ignoring extra_index_urls whenever any override is present, which breaks support for partial overrides. Feedback suggests refining the early-return condition to ensure that auto-discovery via extra indexes is preserved when necessary. A minor formatting issue with a trailing space in the changelog was also identified.
rickeylev
approved these changes
Apr 16, 2026
Collaborator
|
Does this need to be put into the 2.0 release? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When index_url_overrides is provided for all packages, we no longer need to
call the index at all. This improves performance and aligns with the expected
behavior where overrides should be sufficient.
Fixes #3709