feat: support custom includes post-processing functions#424
Open
mattpolzin wants to merge 1 commit intobeam-community:mainfrom
Open
feat: support custom includes post-processing functions#424mattpolzin wants to merge 1 commit intobeam-community:mainfrom
mattpolzin wants to merge 1 commit intobeam-community:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's nice that this library deduplicates included resources by default but sometimes that isn't quite enough.
Using
Enum.uniq/1works if all instances of a given resource are serialized to the same degree, but sometimes two instances with a given identity (sameidandtype) will have different serialized relationships because of preloading data at different levels.In this case and possibly others, it would be nice to be able to provide a custom function that post-processes the includes instead of relying on
Enum.uniq/1.