Skip to content

Fix Rakefile for Edge Rails #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcreid merged 1 commit into from
Apr 22, 2026
Merged

Fix Rakefile for Edge Rails #793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
begin
require "bundler/setup"
require "bundler/gem_tasks"
require "minitest/test_task"
require "rdoc/task"
Expand Down Expand Up @@ -29,12 +28,18 @@ task default: %i[test rubocop:autocorrect]
namespace :test do
desc "Run tests for all supported Rails versions, with current Ruby version"
task :all do
# I _think_ we have to run `bundle exec rake...` here. But that doesn't mean we have
# to run `bundle exec rake...` when we're just running commands in the shell.
# I believe this is because `rake` will load some gems, and the tests, depending on
# the Rails version, may need to load conflicting versions of the gems.
# When you run a single test in the shell, it hasn't had the intermediate `rake` task
# to load gems, so the problem doesn't arise there.
gemfiles.each do |gemfile|
system("BUNDLE_GEMFILE=#{gemfile} rake test")
system("BUNDLE_GEMFILE=#{gemfile} bundle exec rake test")
end

Dir.chdir("demo")
system("BUNDLE_GEMFILE= rake test:all")
system("bin/rails test:all")
end
end

Expand Down