Skip to content

chore: remove project mentions and stale goroot path #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theFong wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove project mentions and stale goroot path #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,9 @@
],
"go.lintOnSave": "workspace",
"go.testTimeout": "240s",
"go.goroot": "/home/ubuntu/.asdf/installs/golang//go",
"[go][go.mod]": {
"editor.codeActionsOnSave": {
"source.organizeImports": "explicit"
}
}
}
}
3 changes: 0 additions & 3 deletions pkg/cmd/create/doc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,6 @@ Connect to running workspace:
solidity-nextjs-starter 1
akka-http-quickstart-scala 1

Join a project:
brev start new-docs

```

join the project new-docs
Expand Down
15 changes: 1 addition & 14 deletions pkg/cmd/ls/ls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,18 +368,6 @@
func (ls Ls) ShowAllWorkspaces(org *entity.Organization, otherOrgs []entity.Organization, user *entity.User, allWorkspaces []entity.Workspace, gpuLookup map[string]string) {
userWorkspaces := store.FilterForUserWorkspaces(allWorkspaces, user.ID)
ls.displayWorkspacesAndHelp(org, otherOrgs, userWorkspaces, allWorkspaces, gpuLookup)

projects := virtualproject.NewVirtualProjects(allWorkspaces)

var unjoinedProjects []virtualproject.VirtualProject
for _, p := range projects {
wks := p.GetUserWorkspaces(user.ID)
if len(wks) == 0 {
unjoinedProjects = append(unjoinedProjects, p)
}
}

displayProjects(ls.terminal, org.Name, unjoinedProjects)
}

func (ls Ls) ShowUserWorkspaces(org *entity.Organization, otherOrgs []entity.Organization, user *entity.User, allWorkspaces []entity.Workspace, gpuLookup map[string]string) {
Expand All @@ -395,7 +383,7 @@
ls.terminal.Vprintf("%s", ls.terminal.Green("See teammates' instances:\n"))
ls.terminal.Vprintf("%s", ls.terminal.Yellow("\tbrev ls --all\n"))
} else {
ls.terminal.Vprintf("%s", ls.terminal.Green("Start a new instance:\n"))
ls.terminal.Vprintf("%s", ls.terminal.Green("Create a new instance:\n"))
}
if len(otherOrgs) > 1 {
ls.terminal.Vprintf("%s", ls.terminal.Green("Switch to another org:\n"))
Expand All @@ -409,7 +397,6 @@
fmt.Print("\n")

displayLsResetBreadCrumb(ls.terminal, userWorkspaces)
// displayLsConnectBreadCrumb(ls.terminal, userWorkspaces)
}
}

Expand Down Expand Up @@ -636,7 +623,7 @@
return status
}

func getWorkspaceDisplayStatus(w entity.Workspace) string {

Check failure on line 626 in pkg/cmd/ls/ls.go

View workflow job for this annotation

GitHub Actions / ci (ubuntu-22.04) 

func displayProjects is unused (unused)

Check failure on line 626 in pkg/cmd/ls/ls.go

View workflow job for this annotation

GitHub Actions / ci (ubuntu-22.04) 

func displayProjects is unused (unused)
status := w.Status
if w.Status == entity.Running && w.HealthStatus == entity.Unhealthy {
status = w.HealthStatus
Expand Down Expand Up @@ -749,7 +736,7 @@
nodes, err := ls.listNodes(org)
if err != nil {
return breverrors.WrapAndTrace(err)
}

Check failure on line 739 in pkg/cmd/ls/ls.go

View workflow job for this annotation

GitHub Actions / ci (ubuntu-22.04) 

func displayProjectsTable is unused (unused)

Check failure on line 739 in pkg/cmd/ls/ls.go

View workflow job for this annotation

GitHub Actions / ci (ubuntu-22.04) 

func displayProjectsTable is unused (unused)

if len(nodes) == 0 {
if ls.jsonOutput {
Expand Down
3 changes: 0 additions & 3 deletions pkg/cmd/start/doc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,6 @@ Connect to running workspace:
solidity-nextjs-starter 1
akka-http-quickstart-scala 1

Join a project:
brev start new-docs

```

join the project new-docs
Expand Down
3 changes: 0 additions & 3 deletions pkg/cmd/status/doc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,6 @@ Connect to running workspace:
solidity-nextjs-starter 1
akka-http-quickstart-scala 1

Join a project:
brev start new-docs

```

join the project new-docs
Expand Down
Loading