fix: filter correct disk image during boot disk selection#110
Open
aditsharma55 wants to merge 1 commit intomainfrom
Open
fix: filter correct disk image during boot disk selection#110aditsharma55 wants to merge 1 commit intomainfrom
aditsharma55 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
Image selection — pagination fix:
The old code used Image().List() which only returned the first page of results. With a small default page size, ubuntu24.04-cuda13.0 could be omitted entirely. Replaced with Image().Filter() which auto-paginates via the SDK iterator.
Image selection — score-based ranking:
The old if/else matching was order-dependent and first-match-wins. The new approach scores every non-ARM64 image using a tiered system
Cloud-init cleanup:
Removed iptables-persistent package, the netfilter-persistent.service systemd ordering drop-in, and the netfilter-persistent save command. These were added for a previous image that shipped with netfilter-persistent pre-installed; the current image does not have it, and these commands caused cloud-init to fail.
Relevant Linear Ticket:
https://linear.app/nvidia/issue/BRE2-901/issue-when-deploying-nebius-h100