Conversation
Creates a `Formatters` enum with static, thread-safe instances of `ByteCountFormatter` and `ISO8601DateFormatter` to eliminate the heavy CPU and memory allocation cost of instantiating new formatters (or using class methods that instantiate them internally) during hot paths like UI list rendering and logging. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 390304bee2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| static let byteCount: ByteCountFormatter = { | ||
| let formatter = ByteCountFormatter() | ||
| formatter.countStyle = .file | ||
| return formatter | ||
| }() |
There was a problem hiding this comment.
Promoting ByteCountFormatter to the global singleton Formatters.byteCount introduces shared mutable formatter state across concurrency domains: it is now called from CacheCleaner.logCleanup (an actor context) and also from @MainActor UI/view-model formatting paths (for example CacheoutViewModel and view rendering), so those calls can overlap and race on a non-Sendable Foundation formatter instance. This can produce incorrect formatted strings or intermittent crashes under load, and it also blocks Swift 6 strict-concurrency adoption (the compiler flags this pattern as concurrency-unsafe).
Useful? React with 👍 / 👎.
1 participant
💡 What: Centralized
ByteCountFormatterandISO8601DateFormatterinto a sharedFormattersenum.🎯 Why: Instantiating
ByteCountFormatter(even via the class method) andISO8601DateFormatteris computationally expensive and was being done repeatedly on hot paths (e.g., list rendering and tight loops).📊 Impact: Significantly reduces object allocations and memory churn, improving list scroll performance and lowering CPU usage during updates.
🔬 Measurement: Observe CPU profiling/allocations instruments; verify UI still shows correct string representations for file sizes and dates.
PR created automatically by Jules for task 8337031418508352930 started by @acebytes