Skip to content

⚡ Bolt: Centralize Foundation formatters to avoid expensive allocations#159

Open
acebytes wants to merge 1 commit intomainfrom
bolt-centralize-formatters-9348143352197494619
Open

⚡ Bolt: Centralize Foundation formatters to avoid expensive allocations#159
acebytes wants to merge 1 commit intomainfrom
bolt-centralize-formatters-9348143352197494619

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What: Replaced all inline instantiations of ByteCountFormatter and ISO8601DateFormatter with shared static instances.
🎯 Why: Instantiating formatters is computationally expensive in Swift. Reusing them avoids repeated allocation overhead, especially in UI updates and loops.
📊 Impact: Eliminates redundant formatter allocations during state updates, lowering memory pressure and improving UI responsiveness.
🔬 Measurement: Verify tests pass.


PR created automatically by Jules for task 9348143352197494619 started by @acebytes

…d allocations

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2fd8da0078

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

import Foundation

enum Formatters {
static let byteCountFormatter: ByteCountFormatter = {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid sharing non-Sendable formatters across actors

ByteCountFormatter and ISO8601DateFormatter are non-Sendable reference types, so putting them in process-wide static properties creates shared mutable state that is accessed from different isolation domains (for example, @MainActor UI formatting in CacheoutViewModel and background cleanup logging in CacheCleaner). During a cleanup run these calls can overlap, which risks formatter races (incorrect output or crashes) and already trips Swift 6 concurrency diagnostics for unsafe global state. Prefer actor-local instances, @MainActor isolation, or explicit synchronization instead of a global singleton formatter.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant