Skip to content

🎨 Palette: Improve CategoryRow hit target and accessibility#161

Open
acebytes wants to merge 1 commit intomainfrom
palette/category-row-accessibility-13602343835282353266
Open

🎨 Palette: Improve CategoryRow hit target and accessibility#161
acebytes wants to merge 1 commit intomainfrom
palette/category-row-accessibility-13602343835282353266

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What: Wrapped the entire CategoryRow in a Button with a rectangular hit area instead of restricting the clickable region to just the tiny checkbox circle.

🎯 Why: The previous design made it difficult to toggle cache categories because the touch/click target was far too small. Additionally, VoiceOver read every element in the row separately, which was tedious.

📸 Before/After:
(Visual layout remains unchanged due to .buttonStyle(.plain) usage, but the entire row now reacts to taps and cursor clicks.)

Accessibility: Added .accessibilityElement(children: .combine) and an .isSelected trait. Screen readers will now announce the entire row's contents succinctly as a single interactive element and correctly report its toggle state.


PR created automatically by Jules for task 13602343835282353266 started by @acebytes

Wrapped the entire CategoryRow HStack in a Button to expand the hit target area, applying `.contentShape(Rectangle())` so padded areas remain clickable. Consolidated VoiceOver navigation using `.accessibilityElement(children: .combine)` and added the `.isSelected` trait.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant