Conversation
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Wrapped
CategoryRowandNodeModulesRowHStackcomponents inButtons and applied.contentShape(Rectangle())to make the entire row space clickable.🎯 Why:
To improve UX by expanding the hit targets for list items. Previously, only the specific child elements within the
HStackwere clickable, making interaction difficult, especially on smaller targets.📸 Before/After:
N/A (Visual appearance remains the same, only the clickable area and accessibility semantics changed).
♿ Accessibility:
Added
.accessibilityElement(children: .combine)to group the row elements into a single cohesive entity for VoiceOver, and added.accessibilityAddTraits(.isSelected)to properly convey the selection state to assistive technologies. Also added an.accessibilityHintto clarify the double-tap action.PR created automatically by Jules for task 15550676834184062368 started by @acebytes