π‘οΈ Sentinel: Replace shell execution with direct Process#166
π‘οΈ Sentinel: Replace shell execution with direct Process#166
Conversation
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df214410c0
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| process.executableURL = URL(fileURLWithPath: "/usr/bin/which") | ||
| process.arguments = [tool] | ||
| process.standardOutput = FileHandle.nullDevice | ||
| process.standardError = FileHandle.nullDevice |
There was a problem hiding this comment.
Preserve PATH overrides in toolExists process
toolExists now runs /usr/bin/which with the inherited environment, but the previous implementation called shell(...), which explicitly set PATH to include /opt/homebrew/bin and /usr/local/bin (see the shell helper below). In macOS app contexts launched without a full login shell environment, this can make which brew/which npm return not found even when installed, so probed cache categories are silently skipped. Set process.environment here (or reuse the same PATH normalization) to avoid this regression.
Useful? React with πΒ / π.
π‘ What: Replaced
/bin/bashstring interpolation in thetoolExistshelper withinSources/Cacheout/Models/CacheCategory.swiftwith a secure, directFoundation.Processcall to/usr/bin/which.π― Why: To eliminate potential command injection risks that exist when passing arbitrary strings to a shell, and to safely suppress standard output and standard error using
FileHandle.nullDevicewithout relying on shell features like2>/dev/null.PR created automatically by Jules for task 372132951508066097 started by @acebytes