Skip to content

πŸ›‘οΈ Sentinel: Replace shell execution with direct Process#166

Open
acebytes wants to merge 1 commit intomainfrom
sentinel/fix-command-injection-372132951508066097
Open

πŸ›‘οΈ Sentinel: Replace shell execution with direct Process#166
acebytes wants to merge 1 commit intomainfrom
sentinel/fix-command-injection-372132951508066097

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

πŸ’‘ What: Replaced /bin/bash string interpolation in the toolExists helper within Sources/Cacheout/Models/CacheCategory.swift with a secure, direct Foundation.Process call to /usr/bin/which.
🎯 Why: To eliminate potential command injection risks that exist when passing arbitrary strings to a shell, and to safely suppress standard output and standard error using FileHandle.nullDevice without relying on shell features like 2>/dev/null.


PR created automatically by Jules for task 372132951508066097 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df214410c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +190 to +193
process.executableURL = URL(fileURLWithPath: "/usr/bin/which")
process.arguments = [tool]
process.standardOutput = FileHandle.nullDevice
process.standardError = FileHandle.nullDevice
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve PATH overrides in toolExists process

toolExists now runs /usr/bin/which with the inherited environment, but the previous implementation called shell(...), which explicitly set PATH to include /opt/homebrew/bin and /usr/local/bin (see the shell helper below). In macOS app contexts launched without a full login shell environment, this can make which brew/which npm return not found even when installed, so probed cache categories are silently skipped. Set process.environment here (or reuse the same PATH normalization) to avoid this regression.

Useful? React with πŸ‘Β / πŸ‘Ž.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant