Fixing TODO in web-app-factory.ts. Remove unsafe-inline and implement script nonces.#394
Open
Mohit-Davar wants to merge 1 commit intocameri:mainfrom
Open
Fixing TODO in web-app-factory.ts. Remove unsafe-inline and implement script nonces.#394Mohit-Davar wants to merge 1 commit intocameri:mainfrom
Mohit-Davar wants to merge 1 commit intocameri:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Enhance CSP security by removing unsafe-inline and implementing script nonces
Description
'unsafe-inline'fromscript-srcandstyle-srcdirectives in the Content Security Policy (CSP).noncegenerated per request to allow legitimate scripts while blocking unauthorized inline scripts.TODOcomments regarding CSP security.2.1.1inpackage.jsonandpackage-lock.jsonto reflect these improvements.Related Issue
Fixes documented security TODO in
web-app-factory.ts.Motivation and Context
Eliminating
unsafe-inlineis a critical step in preventing Cross-Site Scripting (XSS) attacks. By moving to a nonce-based CSP, the relay becomes significantly more secure without breaking existing frontend functionality that relies on external resources.How Has This Been Tested?
src/factories/web-app-factory.ts.package.jsonandpackage-lock.json.Screenshots (if appropriate):
Types of changes
Checklist: