Skip to content

Added expires_at filter in message pipeline#403

Open
kushagra0902 wants to merge 1 commit intocameri:mainfrom
kushagra0902:main
Open

Added expires_at filter in message pipeline#403
kushagra0902 wants to merge 1 commit intocameri:mainfrom
kushagra0902:main

Conversation

@kushagra0902
Copy link
Copy Markdown

Description

This PR adds an expires_at filter in the message pipeline. This ensures that the events that are expired will not be given to the users

Related Issue

#401

Motivation and Context

Earlier, only the deleted_At filter was used in the message pipeline. This made users get expired events also. This poses a problem, especially in gift-wrapped events.

How Has This Been Tested?

Both manual and unit testing have been performed. A relay server was spun up, and messages with the expires_At field were sent and then retrieved after expiry time. The behaviour matched the expected behaviour. All the older tests, EsLint checks and new tests were run and tested.

Screenshots (if appropriate):

N/A

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [ x I have added tests to cover my code changes.
  • [ x] All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants