fix: serve real home page instead of redirecting, add templated pages#409
Open
CKodidela wants to merge 1 commit intocameri:mainfrom
Open
fix: serve real home page instead of redirecting, add templated pages#409CKodidela wants to merge 1 commit intocameri:mainfrom
CKodidela wants to merge 1 commit intocameri:mainfrom
Conversation
Previously, visiting the relay's home page resulted in a 301 permanent
redirect to /invoices when payments were enabled, or a bare text response
when payments were disabled. Neither gave relay operators a real home page,
and the 301 caused browsers to cache the redirect permanently — making it
impossible to change home page behaviour later without users clearing cache.
Changes:
- / now always serves index.html, a proper home page that works with and
without payments. When admission fees are enabled, a payment card and
link to /invoices is shown; otherwise an "open relay" card is shown.
Template variables: {{name}}, {{description}}, {{relay_url}}, {{amount}},
{{payments_section_class}}, {{no_payments_section_class}}, {{nonce}}.
- The old index.html (admission fee form) is renamed to get-invoice.html,
served by GET /invoices. The ToS link now points to /terms instead of
an embedded modal.
- The old invoices.html (payment result page) is renamed to post-invoice.html,
served after POST /invoices. The rename reflects what the page actually is.
- privacy.html template added and served at GET /privacy.
- Old index.html and invoices.html remain in resources/ for reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, visiting the relay's home page resulted in a 301 permanent redirect to /invoices when payments were
enabled, or a bare text response when payments were disabled. Neither gave relay operators a real home page, and the
301 caused browsers to cache the redirect permanently making it impossible to change home page behaviour later
without users clearing cache.
Changes:
enabled, a payment card and link to /invoices is shown; otherwise an "open relay" card is shown. Template variables:
{{name}}, {{description}}, {{relay_url}}, {{amount}}, {{payments_section_class}}, {{no_payments_section_class}},
{{nonce}}.
points to /terms instead of an embedded modal.
reflects what the page actually is.
Description
Replaces the broken home page behaviour with a proper templated home page. All five templates (
index.html,get-invoice.html,post-invoice.html,terms.html,privacy.html) are user-modifiable files inresources/. Thehome page conditionally shows or hides the admission fee section using CSS class template variables, so it works
correctly whether payments are enabled or not.
Related Issue
Closes #269
Motivation and Context
The 301 redirect was a bug browsers cache it permanently, so any future change to the home page would be invisible
to returning visitors until they manually cleared their cache. Beyond the redirect fix, relay operators (especially
those running private/whitelist-only relays with no payments) had no home page at all, and there was no privacy policy
page despite many jurisdictions requiring one.
How Has This Been Tested?
Manually verified both payment-enabled and payment-disabled paths render the correct home page content. Verified
GET /invoicesservesget-invoice.html,POST /invoicesservespost-invoice.html,GET /termsandGET /privacyboth render correctly. Confirmed
application/nostr+jsonrequests to/still return the relay information documentunchanged.
Types of changes
Checklist