Skip to content

fix(crafter): use deterministic filename for AI config collector #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waveywaves wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −11
Open

fix(crafter): use deterministic filename for AI config collector #2943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11c6de4
fix(crafter): use deterministic filename for AI config collector
waveywaves Mar 27, 2026
5dc7342
fix(crafter): address review feedback - revert PR metadata, simplify …
waveywaves Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions pkg/attestation/crafter/collector_aiagentconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"encoding/json"
"fmt"
"os"
"path/filepath"
"sort"

schemaapi "github.com/chainloop-dev/chainloop/app/controlplane/api/workflowcontract/v1"
Expand Down Expand Up @@ -99,20 +100,16 @@ func (c *AIAgentConfigCollector) uploadAgentConfig(
return fmt.Errorf("marshaling AI agent config for %s: %w", agentName, err)
}

tmpFile, err := os.CreateTemp("", fmt.Sprintf("ai-agent-config-%s-*.json", agentName))
if err != nil {
return fmt.Errorf("creating temp file: %w", err)
}
defer os.Remove(tmpFile.Name())

if _, err := tmpFile.Write(jsonData); err != nil {
tmpFile.Close()
// Use a constant filename per agent so retries produce the same
// Artifact.Name (via fileStats -> os.Stat().Name()).
materialName := fmt.Sprintf("ai-agent-config-%s", agentName)
tmpPath := filepath.Join(os.TempDir(), fmt.Sprintf("%s.json", materialName))
if err := os.WriteFile(tmpPath, jsonData, 0o600); err != nil {
return fmt.Errorf("writing temp file: %w", err)
}
tmpFile.Close()
defer os.Remove(tmpPath)

materialName := fmt.Sprintf("ai-agent-config-%s", agentName)
if _, err := cr.AddMaterialContractFree(ctx, attestationID, schemaapi.CraftingSchema_Material_CHAINLOOP_AI_AGENT_CONFIG.String(), materialName, tmpFile.Name(), casBackend, nil); err != nil {
if _, err := cr.AddMaterialContractFree(ctx, attestationID, schemaapi.CraftingSchema_Material_CHAINLOOP_AI_AGENT_CONFIG.String(), materialName, tmpPath, casBackend, nil); err != nil {
return fmt.Errorf("adding AI agent config material for %s: %w", agentName, err)
}

Expand Down
Loading