Bind health-check listeners on binding_ip and v4v6#904
Open
s4heid wants to merge 1 commit intocloudfoundry:masterfrom
Open
Bind health-check listeners on binding_ip and v4v6#904s4heid wants to merge 1 commit intocloudfoundry:masterfrom
binding_ip and v4v6#904s4heid wants to merge 1 commit intocloudfoundry:masterfrom
Conversation
The four health-check listeners (`health_check_http_url`, its PROXY protocol variant, and the per-tcp-proxy `health_check_http_tcp-<name>` pair) previously bound on `:<port>`, which is IPv4-wildcard only. On IPv6-only deployments (`binding_ip: "::"`) the listeners were unreachable, causing monit host checks against `localhost` (IPv4) to fail and restart HAProxy. Bind them on `ha_proxy.binding_ip` and append `v4v6` like the other frontends so dual-stack works when `ha_proxy.v4v6` is enabled. Behavior change: when `binding_ip` is set to a specific IPv4 address, the health-check listeners now bind only on that address instead of all IPv4 interfaces. Operators probing health via a different NIC must update their probe targets accordingly. Co-authored-by: jakobve <36446012+jakobve@users.noreply.github.com>
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four health-check listeners (
health_check_http_url, its proxy protocol variant, and the per-tcp-proxyhealth_check_http_tcp-<name>pair) previously bound on:<port>, which is IPv4-wildcard only. On IPv6-only deployments (binding_ip: "::") the listeners were unreachable, causing monit host checks againstlocalhost(IPv4) to fail and restart HAProxy.Bind them on
ha_proxy.binding_ipand appendv4v6like the other frontends so dual-stack works whenha_proxy.v4v6is enabled.Behavior change: when
binding_ipis set to a specific IPv4 address, the health-check listeners now bind only on that address instead of all IPv4 interfaces. Operators probing health via a different NIC must update their probe targets accordingly.