Update test environment to report failed assertions#122
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the test runtime configuration so PHP assert() failures are actually evaluated and reported during test runs, and adjusts CI to use PHP development ini settings (per the referenced framework-x discussion).
Changes:
- Enable assertion-related ini settings in PHPUnit configs (
assert.active,assert.exception,assert.bail). - Update GitHub Actions CI to use the PHP “development” ini template via
shivammathur/setup-php.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
phpunit.xml.legacy |
Adds assertion ini settings for legacy PHPUnit runs. |
phpunit.xml.dist |
Adds assertion ini settings for modern PHPUnit runs. |
.github/workflows/ci.yml |
Switches CI PHP configuration to ini-file: development. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the test environment to report failed assertions and use PHP development settings as discussed in clue/framework-x#199.
Builds on top of #121 and clue/framework-x#199