Skip to content

Added Hermione profile#354

Open
hcelestain wants to merge 1 commit intocnerg:mainfrom
hcelestain:add_myself
Open

Added Hermione profile#354
hcelestain wants to merge 1 commit intocnerg:mainfrom
hcelestain:add_myself

Conversation

@hcelestain
Copy link
Copy Markdown

Hi! Adding my profile to the Undergrad roster.

Copy link
Copy Markdown
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this addition @hcelestain !

I've left a couple of comments. If you make changes and push them to the same branch it will automatically update the pull request with the new files.

I'm sure you can get someone else to walk you through the process, if it will help.

Comment thread _data/people.yml
Comment on lines +67 to +70
- name: "Hermione Celestain"
url: HC
Role: "Undergraduate Student"
image: Hermione.jpg
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be indented to match lines above

Comment thread community/people/index.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file probably shouldn't be changed

role: Undergraduate Student
image: Hermione.jpg
email: celestain@wisc.edu
phone: "865/3303654"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to CNERG! I just noticed this and wanted to say that a phone number is optional. We don't get office phones like @gonuke does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants