DRYD-2094: Replace ClientResponse with Response#528
Open
mikejritter wants to merge 2 commits intocollectionspace:developfrom
Open
DRYD-2094: Replace ClientResponse with Response#528mikejritter wants to merge 2 commits intocollectionspace:developfrom
mikejritter wants to merge 2 commits intocollectionspace:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2094
This is another small change for RESTEasy 3.x before we upgrade so that we can deploy to dev and do some early testing there. This should also make the move to the jakarta namespace a bit easier as the imports are all the same.
When running the integration tests there was an error in the AccountClientTest related to the hibernate.cfg.xml and caused the update to the plugin in the pom.xml.
How should this be tested? Do these changes have associated tests?
Most of these have no functional changes that need to be tested. Only the ClaimProxy had return types updated should have its test suite ran to check as that is the only usage.
For the plugin configuration, in the project directory for
services/account/client, runmvn clean package -DskipTestsand see that the hibernate.xml.cfg which is written totarget/test-classeshas correct settings for the database configuration. The tests inservices/account/clientcan be ran as well.Dependencies for merging? Releasing to production?
None
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter ran the integration tests locally
Have any new security vulnerabilities been handled?
n/a