feat: nullable has-one returns null, add $hasOne for mutations#15
Closed
feat: nullable has-one returns null, add $hasOne for mutations#15
Conversation
…r mutations
Nullable has-one relations (e.g. `author: Author | null`) now return `null`
from entity field access when the relation is disconnected, instead of always
returning a HasOneAccessor with a placeholder entity.
For mutation access (connect/disconnect), use `entity.$hasOne('fieldName')`
which always returns the HasOneAccessor regardless of connection state.
matej21
added a commit
that referenced
this pull request
Apr 10, 2026
Alternative approach to #15. Instead of returning null for disconnected nullable has-one relations, keep the placeholder entity pattern from contember-oss binding. This provides a consistent API where has-one always returns an accessor, and users check connection state via $isConnected or $state. Changes: - Add $isConnected boolean getter to HasOneHandle and HasOneRefInterface - Fix schema definitions to include nullable: true where entity types have | null (enables correct $remove() behavior: disconnect vs delete) - Add placeholder behavior tests for nullable has-one relations Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
matej21
added a commit
that referenced
this pull request
Apr 10, 2026
Alternative approach to #15. Instead of returning null for disconnected nullable has-one relations, keep the placeholder entity pattern from contember-oss binding. This provides a consistent API where has-one always returns an accessor, and users check connection state via $isConnected or $state. Changes: - Add $isConnected boolean getter to HasOneHandle and HasOneRefInterface - Fix schema definitions to include nullable: true where entity types have | null (enables correct $remove() behavior: disconnect vs delete) - Add placeholder behavior tests for nullable has-one relations Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Fixed in #16. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
author: Author | null) now returnnullfrom entity field access when disconnected, instead of always returning aHasOneAccessorwith a placeholder entityentity.$hasOne('fieldName')method always returnsHasOneAccessorregardless of connection state — for mutation access ($connect,$disconnect,$reset, etc.)HasOneHandle.hasOne()delegation for nested$hasOneaccess (e.g.entity.author.$hasOne('avatar'))API pattern
Test plan
bun run typecheck)