Allow infinite retries for workflows

[matheusandre1]

Description

I added the requested validation and created the test according to the project's naming convention.

Issue reference

Please reference the issue this PR will close: #870

• Code compiles correctly
• Created/updated tests
• Extended the documentation

[acroca]

Also, I think it'd be useful to add a scenario for the infinite retries to the examples/workflow/simple.py. The example could be just a counter that makes it fail 10 times, and succeed after all those failures, and assert the workflow completed successfully. makes sense?

[matheusandre1]

I adjusted the WorkflowRuntime start time so it doesn't fail when the worker isn't ready within the expected time.

[acroca]

Thanks!
It'd be better if you send different commits instead of keeping updating a single commit, this way I can track what's added every time instead of having to review everything every time.

[acroca]

Hm do you mind explaining this change? I feel it'd be good to raise an an error because the worker is not ready.

[matheusandre1]

It was due to a pipeline error, where the attempts were altered.

[matheusandre1]

I apologize, I thought I had to do a squash commit.

[matheusandre1]

pr a pipeline tb failed again, I don't understand the error.

[sicoyle]

Hi! 👋 can you try running these cmds pls to fix the DCO build step?

In your local branch, run: git rebase HEAD~4 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin issue870

[CasperGN]

@matheusandre1 can you address the comments?

[matheusandre1]

@CasperGN I didn't understand, I corrected what was requested.

[matheusandre1]

@CasperGN , I'm having trouble understanding the CI errors; check examples.

[CasperGN]

@CasperGN , I'm having trouble understanding the CI errors; check examples.

Sorry I wasn't explicit enough. There's a couple of test failures that looks related to the infinite retries. The problem is deeper though:

======================================================================
ERROR: test_allow_infinite_max_number_of_attempts (test_retry_policy.RetryPolicyTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/python-sdk/python-sdk/ext/dapr-ext-workflow/tests/test_retry_policy.py", line 39, in test_allow_infinite_max_number_of_attempts
    retry_policy = RetryPolicy(
  File "/home/runner/work/python-sdk/python-sdk/ext/dapr-ext-workflow/dapr/ext/workflow/retry_policy.py", line 63, in __init__
    self._obj = task.RetryPolicy(
  File "/home/runner/work/python-sdk/python-sdk/.tox/py310/lib/python3.10/site-packages/durabletask/task.py", line 582, in __init__
    raise ValueError("max_number_of_attempts must be >= 1")
ValueError: max_number_of_attempts must be >= 1

If you note the last line, the value error is thrown from durable task so this PR cannot be alone - it needs to follow with a PR in durable task that allow propagating 0 and -1 into the retries.

Would it also be possible, when you get both repo PRs ready, to run it locally with an example of infinite retries?

[acroca]

@matheusandre1 I updated the PR, I hope you don't mind. We've moved durabletask to be in-repo now, so we don't need another PR for this.

[codecov]

Codecov Report

❌ Patch coverage is 97.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.55%. Comparing base (bffb749) to head (c699276).
⚠️ Report is 104 commits behind head on main.

Files with missing lines	Patch %	Lines
...w/tests/durabletask/test_orchestration_executor.py	97.18%	2 Missing ⚠️
...xt-workflow/dapr/ext/workflow/_durabletask/task.py	93.75%	1 Missing ⚠️
ext/dapr-ext-workflow/tests/test_retry_policy.py	96.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   86.63%   81.55%   -5.08%     
==========================================
  Files          84      140      +56     
  Lines        4473    13609    +9136     
==========================================
+ Hits         3875    11099    +7224     
- Misses        598     2510    +1912     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Enables “infinite retries” for workflow/activity retry policies by allowing max_number_of_attempts=-1, and adds tests plus an updated workflow example to validate the behavior end-to-end.

Changes:

• Allow max_number_of_attempts=-1 in both the public RetryPolicy wrapper and the internal durabletask RetryPolicy, with updated validation/error messaging.
• Update retry scheduling logic to treat -1 as “no attempt cap” when computing retry delays.
• Add unit tests (policy validation, delay computation, executor rescheduling) and update the workflow example + README expectations.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ext/dapr-ext-workflow/tests/test_retry_policy.py	Adds unit tests for wrapper RetryPolicy validation and a simple infinite-retry behavior check.
ext/dapr-ext-workflow/tests/durabletask/test_task.py	Adds tests for durabletask RetryPolicy validation and RetryableTask.compute_next_delay() behavior for infinite/timeout/capped retries.
ext/dapr-ext-workflow/tests/durabletask/test_orchestration_executor.py	Adds executor-level tests ensuring activities and sub-orchestrations keep retrying when max_number_of_attempts=-1.
ext/dapr-ext-workflow/dapr/ext/workflow/retry_policy.py	Permits -1 and documents it as infinite retries in the public API wrapper.
ext/dapr-ext-workflow/dapr/ext/workflow/_durabletask/task.py	Permits -1 and skips the attempt-cap check in RetryableTask.compute_next_delay().
examples/workflow/simple.py	Demonstrates infinite-retry activity usage and asserts expected retry counts.
examples/workflow/README.md	Updates expected output lines and increases the step timeout to account for the longer-running example.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.