backport: Merge bitcoin#30170, 30026, 30017, 29961, 29904, 29910, 29849

[vijaydasmp]

bitcoin backport

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[thepastaclaw]

✅ Review complete (commit 9fb5593)

[coderabbitai]

Walkthrough

This pull request refactors URL decoding functionality and build system dependencies. The changes remove the USE_LIBEVENT conditional from the build system, consolidating URL decoding into an unconditional library target. The urlDecode function is renamed to UrlDecode with a new signature accepting std::string_view and uses a custom percent-decoder implementation instead of libevent's evhttp_uridecode. The URL_DECODE global function pointer variable is removed from multiple compilation units. The subprocess header is renamed from .hpp to .h, and several functions are removed. Time-related orphan expiration constants are converted from int64_t to strongly-typed duration literals. Minor type safety improvements include explicit size_t casts in bit-shift operations and addition of assertion helpers in tests.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~35 minutes

Possibly related PRs

• backport: bitcoin#24254, #24397, #24521, #24523, #25235, #25696, #25723, #26196, #27449, #28002, #28967, #28981, #29489 (external signer, boost) #6913: Modifies build and public include surface for subprocess utilities, affecting header naming and Makefile entries similarly to this PR's subprocess refactoring.

Suggested reviewers

• UdjinM6
• kwvg
• PastaPastaPasta

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 38.89% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title references multiple upstream Bitcoin PR numbers (30170, 30026, 30017, 29961, 29904, 29910, 29849) that correspond to the actual changes across URL decoding, subprocess header refactoring, time typing, and other code improvements shown in the changeset.
Description check	✅ Passed	The description 'bitcoin backport' is minimal but clearly indicates this is a backport of Bitcoin upstream changes, which aligns with the PR's actual purpose of merging multiple Bitcoin commits.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

src/test/fuzz/poolresource.cpp (1)

68-68: Optional: Consider size_t{1} instead of 1U for consistency.

For complete consistency with the other changes in this line, you could replace - 1U with - size_t{1}. This is purely a style preference and doesn't affect correctness, as 1U will be promoted to size_t during the subtraction.

✨ Optional consistency fix

-        size_t size = m_provider.ConsumeIntegralInRange<size_t>(size_t{1} << size_bits, (size_t{1} << (size_bits + 1)) - 1U) << alignment_bits;
+        size_t size = m_provider.ConsumeIntegralInRange<size_t>(size_t{1} << size_bits, (size_t{1} << (size_bits + 1)) - size_t{1}) << alignment_bits;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/test/fuzz/poolresource.cpp` at line 68, Replace the literal unsigned int
used in the upper bound with a size_t brace-init for consistency: in the call to
m_provider.ConsumeIntegralInRange<size_t> change the upper bound expression from
((size_t{1} << (size_bits + 1)) - 1U) to ((size_t{1} << (size_bits + 1)) -
size_t{1}) so both operands are size_t; this edit is in the expression passed to
m_provider.ConsumeIntegralInRange<size_t>.

src/test/validation_chainstate_tests.cpp (1)

112-119: Replace Assert(...) with BOOST_REQUIRE for test-scoped failure handling.

In test code, Assert(...) calls abort() and terminates the entire test process immediately. Using BOOST_REQUIRE/BOOST_REQUIRE_MESSAGE instead aborts only the current test case, allowing other test cases in the suite to continue—critical for test-run completeness. This also aligns with the project's requirement that unit tests in src/test/ use Boost::Test.

Suggested refactor

-    CChainState& background_cs{*Assert([&]() -> CChainState* {
+    CChainState* background_cs_ptr{[&]() -> CChainState* {
         for (CChainState* cs : chainman.GetAll()) {
             if (cs != &chainman.ActiveChainstate()) {
                 return cs;
             }
         }
         return nullptr;
-    }())};
+    }()};
+    BOOST_REQUIRE_MESSAGE(background_cs_ptr != nullptr, "Background chainstate not found");
+    CChainState& background_cs{*background_cs_ptr};

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/test/validation_chainstate_tests.cpp` around lines 112 - 119, The test
uses Assert(...) which aborts the whole process; replace it with Boost checks:
iterate over chainman.GetAll() to find the non-active CChainState* (same logic
as the lambda), store it in a CChainState* variable, then use
BOOST_REQUIRE_MESSAGE(found != nullptr, "background chainstate not found") to
fail only this test if null; finally bind CChainState& background_cs to *found
(preserving the original variable name background_cs and using
chainman.ActiveChainstate() to identify the active one).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/test/fuzz/poolresource.cpp`:
- Line 68: Replace the literal unsigned int used in the upper bound with a
size_t brace-init for consistency: in the call to
m_provider.ConsumeIntegralInRange<size_t> change the upper bound expression from
((size_t{1} << (size_bits + 1)) - 1U) to ((size_t{1} << (size_bits + 1)) -
size_t{1}) so both operands are size_t; this edit is in the expression passed to
m_provider.ConsumeIntegralInRange<size_t>.

In `@src/test/validation_chainstate_tests.cpp`:
- Around line 112-119: The test uses Assert(...) which aborts the whole process;
replace it with Boost checks: iterate over chainman.GetAll() to find the
non-active CChainState* (same logic as the lambda), store it in a CChainState*
variable, then use BOOST_REQUIRE_MESSAGE(found != nullptr, "background
chainstate not found") to fail only this test if null; finally bind CChainState&
background_cs to *found (preserving the original variable name background_cs and
using chainman.ActiveChainstate() to identify the active one).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf1c9f39-4bdd-4412-b32b-ce4ffdc697a7

📥 Commits

Reviewing files that changed from the base of the PR and between 31c8464 and 9fb5593.

📒 Files selected for processing (21)

• configure.ac
• src/Makefile.am
• src/Makefile.test.include
• src/bitcoin-cli.cpp
• src/bitcoin-wallet.cpp
• src/bitcoind.cpp
• src/common/run_command.cpp
• src/common/url.cpp
• src/common/url.h
• src/qt/main.cpp
• src/test/common_url_tests.cpp
• src/test/fuzz/poolresource.cpp
• src/test/fuzz/string.cpp
• src/test/system_tests.cpp
• src/test/util/setup_common.cpp
• src/test/validation_chainstate_tests.cpp
• src/txorphanage.cpp
• src/txorphanage.h
• src/util/subprocess.h
• src/wallet/rpc/util.cpp
• test/lint/lint-spelling.py

💤 Files with no reviewable changes (6)

• src/bitcoin-wallet.cpp
• src/qt/main.cpp
• src/test/util/setup_common.cpp
• src/bitcoin-cli.cpp
• src/bitcoind.cpp
• configure.ac

[thepastaclaw]

Code Review

I verified the exact patch scope for PR #7257 against the checked-out source at 9fb5593d467374770847be704149ad3cfbdac7f9. The successful agent section (codex-general) reported no findings, and direct inspection of the touched URL decoding, orphanage time-type cleanup, and subprocess header rename did not reveal a concrete correctness, Dash-specific interaction, or build-integration issue within this diff.

Reviewed commit: 9fb5593